2022-01-17 08:04:11

by Tom Rix

Subject: [PATCH] ath11k: fix error handling in ath11k_qmi_assign_target_mem_chunk()

From: Tom Rix <[email protected]>

Clang static analysis reports this problem
qmi.c:1935:5: warning: Undefined or garbage value returned to caller
return ret;
^~~~~~~~~~

ret is uninitialized. When of_parse_phandle() fails, garbage is
returned. So return -EINVAL.

Fixes: 6ac04bdc5edb ("ath11k: Use reserved host DDR addresses from DT for PCI devices")
Signed-off-by: Tom Rix <[email protected]>
---
drivers/net/wireless/ath/ath11k/qmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath11k/qmi.c b/drivers/net/wireless/ath/ath11k/qmi.c
index 65d3c6ba35ae6..81b2304b1fdeb 100644
--- a/drivers/net/wireless/ath/ath11k/qmi.c
+++ b/drivers/net/wireless/ath/ath11k/qmi.c
@@ -1932,7 +1932,7 @@ static int ath11k_qmi_assign_target_mem_chunk(struct ath11k_base *ab)
if (!hremote_node) {
ath11k_dbg(ab, ATH11K_DBG_QMI,
"qmi fail to get hremote_node\n");
- return ret;
+ return -EINVAL;
}

ret = of_address_to_resource(hremote_node, 0, &res);
--
2.26.3

2022-01-18 02:26:06

by Kalle Valo

Subject: Re: [PATCH] ath11k: fix error handling in ath11k_qmi_assign_target_mem_chunk()

[email protected] wrote:

> From: Tom Rix <[email protected]>
>
> Clang static analysis reports this problem
> qmi.c:1935:5: warning: Undefined or garbage value returned to caller
> return ret;
> ^~~~~~~~~~
>
> ret is uninitialized. When of_parse_phandle() fails, garbage is
> returned. So return -EINVAL.
>
> Fixes: 6ac04bdc5edb ("ath11k: Use reserved host DDR addresses from DT for PCI devices")
> Signed-off-by: Tom Rix <[email protected]>

I just applied a fix from Dan:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=ath-next&id=c9b41832dc08

Patch set to Superseded.

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches