2022-02-09 13:45:29

by Wen Gong

Subject: [PATCH] ath11k: fix uninitialized rate_idx in ath11k_dp_tx_update_txcompl()

The rate_idx which passed to ath11k_debugfs_sta_add_tx_stats() by
ath11k_dp_tx_update_txcompl() is not initialized, add initialization
for it.

Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03003-QCAHSPSWPL_V1_V2_SILICONZ_LITE-2

Fixes: 1b8bb94c0612 ("ath11k: report tx bitrate for iw wlan station dump")
Signed-off-by: Wen Gong <[email protected]>
---
drivers/net/wireless/ath/ath11k/dp_tx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath11k/dp_tx.c b/drivers/net/wireless/ath/ath11k/dp_tx.c
index 91d6244b6543..8402961c6688 100644
--- a/drivers/net/wireless/ath/ath11k/dp_tx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_tx.c
@@ -426,7 +426,7 @@ void ath11k_dp_tx_update_txcompl(struct ath11k *ar, struct hal_tx_status *ts)
struct ath11k_sta *arsta;
struct ieee80211_sta *sta;
u16 rate, ru_tones;
- u8 mcs, rate_idx, ofdma;
+ u8 mcs, rate_idx = 0, ofdma;
int ret;

spin_lock_bh(&ab->base_lock);

base-commit: 76680d49b5e0e661bc4abcdaf13fb7e124b4ca08
--
2.31.1

2022-02-14 20:55:52

by Kalle Valo

Subject: Re: [PATCH] ath11k: fix uninitialized rate_idx in ath11k_dp_tx_update_txcompl()

Wen Gong <[email protected]> wrote:

> The rate_idx which passed to ath11k_debugfs_sta_add_tx_stats() by
> ath11k_dp_tx_update_txcompl() is not initialized, add initialization
> for it.
>
> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03003-QCAHSPSWPL_V1_V2_SILICONZ_LITE-2
>
> Fixes: 1b8bb94c0612 ("ath11k: report tx bitrate for iw wlan station dump")
> Signed-off-by: Wen Gong <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

8c4c567fa291 ath11k: fix uninitialized rate_idx in ath11k_dp_tx_update_txcompl()

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches