2022-03-26 21:38:07

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: Re: [PATCH 01/22] orion5x: Replace comments with C99 initializers

Em Sat, 26 Mar 2022 17:58:48 +0100
Benjamin Stürz <[email protected]> escreveu:

> This replaces comments with C99's designated
> initializers because the kernel supports them now.

Please:

1. Split this series per sub-system. It makes no sense to mailbomb all
subsystems for things that won't belong there;

2. Add a patch 00 to the series, in order to make easier to do reviews
like this that are meant to the series as a hole.

Regards,
Mauro
>
> Signed-off-by: Benjamin Stürz <[email protected]>
> ---
> arch/arm/mach-orion5x/dns323-setup.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-orion5x/dns323-setup.c b/arch/arm/mach-orion5x/dns323-setup.c
> index 87cb47220e82..d762248c6512 100644
> --- a/arch/arm/mach-orion5x/dns323-setup.c
> +++ b/arch/arm/mach-orion5x/dns323-setup.c
> @@ -61,9 +61,9 @@
>
> /* Exposed to userspace, do not change */
> enum {
> - DNS323_REV_A1, /* 0 */
> - DNS323_REV_B1, /* 1 */
> - DNS323_REV_C1, /* 2 */
> + DNS323_REV_A1 = 0,
> + DNS323_REV_B1 = 1,
> + DNS323_REV_C1 = 2,
> };
>
>



Thanks,
Mauro