2022-04-12 10:03:20

by Yue Haibing

[permalink] [raw]
Subject: [PATCH] ath11k: Fix build warning without CONFIG_IPV6

drivers/net/wireless/ath/ath11k/mac.c:8175:13: error: ‘ath11k_mac_op_ipv6_changed’ defined but not used [-Werror=unused-function]
static void ath11k_mac_op_ipv6_changed(struct ieee80211_hw *hw,
^~~~~~~~~~~~~~~~~~~~~~~~~~

Wrap it with #ifdef block to fix this.

Fixes: c3c36bfe998b ("ath11k: support ARP and NS offload")
Signed-off-by: YueHaibing <[email protected]>
---
drivers/net/wireless/ath/ath11k/mac.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index ca998fb13b62..18a2994b6d85 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -8151,6 +8151,7 @@ static void ath11k_mac_op_sta_statistics(struct ieee80211_hw *hw,
}
}

+#if IS_ENABLED(CONFIG_IPV6)
static void ath11k_generate_ns_mc_addr(struct ath11k *ar,
struct ath11k_arp_ns_offload *offload)
{
@@ -8245,6 +8246,7 @@ static void ath11k_mac_op_ipv6_changed(struct ieee80211_hw *hw,
/* generate ns multicast address */
ath11k_generate_ns_mc_addr(ar, offload);
}
+#endif

static void ath11k_mac_op_set_rekey_data(struct ieee80211_hw *hw,
struct ieee80211_vif *vif,
--
2.17.1


2022-04-23 11:11:42

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] ath11k: Fix build warning without CONFIG_IPV6

YueHaibing <[email protected]> wrote:

> drivers/net/wireless/ath/ath11k/mac.c:8175:13: error: ‘ath11k_mac_op_ipv6_changed’ defined but not used [-Werror=unused-function]
> static void ath11k_mac_op_ipv6_changed(struct ieee80211_hw *hw,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Wrap it with #ifdef block to fix this.
>
> Fixes: c3c36bfe998b ("ath11k: support ARP and NS offload")
> Signed-off-by: YueHaibing <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

67888630adde ath11k: Fix build warning without CONFIG_IPV6

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches