2022-06-06 14:06:48

by Li Qiong

Subject: [PATCH 2/2] mwl8k: use time_after to replace "jiffies > a"

time_after deals with timer wrapping correctly.

Signed-off-by: Li Qiong <[email protected]>
---
drivers/net/wireless/marvell/mwl8k.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/marvell/mwl8k.c b/drivers/net/wireless/marvell/mwl8k.c
index 864a2ba9efee..2dfb8c10bb57 100644
--- a/drivers/net/wireless/marvell/mwl8k.c
+++ b/drivers/net/wireless/marvell/mwl8k.c
@@ -1880,7 +1880,7 @@ static inline void mwl8k_tx_count_packet(struct ieee80211_sta *sta, u8 tid)
* packets ever exceeds the ampdu_min_traffic threshold, we will allow
* an ampdu stream to be started.
*/
- if (jiffies - tx_stats->start_time > HZ) {
+ if (time_after(jiffies, (unsigned long)tx_stats->start_time + HZ)) {
tx_stats->pkts = 0;
tx_stats->start_time = 0;
} else
--
2.25.1

2022-07-27 10:58:44

by Kalle Valo

Subject: Re: [2/2] wifi: mwl8k: use time_after to replace "jiffies > a"

Li Qiong <[email protected]> wrote:

> time_after deals with timer wrapping correctly.
>
> Signed-off-by: Li Qiong <[email protected]>

Patch applied to wireless-next.git, thanks.

8006bb53ca0f wifi: mwl8k: use time_after to replace "jiffies > a"

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches