2022-07-01 08:35:57

by Xu Qiang

Subject: [PATCH v2 -next] wifi: plfxlc: Use eth_zero_addr() to assign zero address

Using eth_zero_addr() to assign zero address instead of memset().

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Xu Qiang <[email protected]>
---
v2:
- fix typo in commit log
drivers/net/wireless/purelifi/plfxlc/usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/purelifi/plfxlc/usb.c b/drivers/net/wireless/purelifi/plfxlc/usb.c
index 8519cf0adfff..39e54b3787d6 100644
--- a/drivers/net/wireless/purelifi/plfxlc/usb.c
+++ b/drivers/net/wireless/purelifi/plfxlc/usb.c
@@ -562,7 +562,7 @@ static void sta_queue_cleanup_timer_callb(struct timer_list *t)
if (tx->station[sidx].flag & STATION_HEARTBEAT_FLAG) {
tx->station[sidx].flag ^= STATION_HEARTBEAT_FLAG;
} else {
- memset(tx->station[sidx].mac, 0, ETH_ALEN);
+ eth_zero_addr(tx->station[sidx].mac);
tx->station[sidx].flag = 0;
}
}
--
2.17.1

2022-07-27 13:04:12

by Kalle Valo

Subject: Re: [PATCH v2 -next] wifi: plfxlc: Use eth_zero_addr() to assign zero address

Xu Qiang <[email protected]> wrote:

> Using eth_zero_addr() to assign zero address instead of memset().
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Xu Qiang <[email protected]>

Patch applied to wireless-next.git, thanks.

70c898d4bad1 wifi: plfxlc: Use eth_zero_addr() to assign zero address

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches