2022-08-29 12:24:50

by Li Qiong

Subject: [PATCH v2] wifi: brcmfmac: add error code in brcmf_notify_sched_scan_results()

The err code is 0 at the first two "out_err" paths, add error code
'-EINVAL' for these error paths.

Signed-off-by: Li Qiong <[email protected]>
---
v1->v2:
- Modify subject.
- Resend patch and CC to linux-wireless.
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index db45da33adfd..b965649bb0e4 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -3553,6 +3553,7 @@ brcmf_notify_sched_scan_results(struct brcmf_if *ifp,
WARN_ON(status != BRCMF_PNO_SCAN_COMPLETE);
brcmf_dbg(SCAN, "PFN NET FOUND event. count: %d\n", result_count);
if (!result_count) {
+ err = -EINVAL;
bphy_err(drvr, "FALSE PNO Event. (pfn_count == 0)\n");
goto out_err;
}
@@ -3560,6 +3561,7 @@ brcmf_notify_sched_scan_results(struct brcmf_if *ifp,
netinfo_start = brcmf_get_netinfo_array(pfn_result);
datalen = e->datalen - ((void *)netinfo_start - (void *)pfn_result);
if (datalen < result_count * sizeof(*netinfo)) {
+ err = -EINVAL;
bphy_err(drvr, "insufficient event data\n");
goto out_err;
}
--
2.11.0

2022-09-07 07:33:47

by Kalle Valo

Subject: Re: [PATCH v2] wifi: brcmfmac: add error code in brcmf_notify_sched_scan_results()

Li Qiong <[email protected]> wrote:

> The err code is 0 at the first two "out_err" paths, add error code
> '-EINVAL' for these error paths.
>
> Signed-off-by: Li Qiong <[email protected]>

Arend already commented v1:

https://lore.kernel.org/netdev/[email protected]/

Patch set to Changes Requested.

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches