2022-08-29 11:35:13

by CGEL

Subject: [PATCH linux-next] wifi: cfg80211: remove redundant ret variable

From: Jinpeng Cui <[email protected]>

Return value from cfg80211_rx_mgmt() directly instead of
taking this in another redundant variable.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Jinpeng Cui <[email protected]>
---
drivers/net/wireless/microchip/wilc1000/cfg80211.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/microchip/wilc1000/cfg80211.c b/drivers/net/wireless/microchip/wilc1000/cfg80211.c
index f810a56a7ff0..b89047965e78 100644
--- a/drivers/net/wireless/microchip/wilc1000/cfg80211.c
+++ b/drivers/net/wireless/microchip/wilc1000/cfg80211.c
@@ -997,12 +997,11 @@ bool wilc_wfi_mgmt_frame_rx(struct wilc_vif *vif, u8 *buff, u32 size)
{
struct wilc *wl = vif->wilc;
struct wilc_priv *priv = &vif->priv;
- int freq, ret;
+ int freq;

freq = ieee80211_channel_to_frequency(wl->op_ch, NL80211_BAND_2GHZ);
- ret = cfg80211_rx_mgmt(&priv->wdev, freq, 0, buff, size, 0);

- return ret;
+ return cfg80211_rx_mgmt(&priv->wdev, freq, 0, buff, size, 0);
}

void wilc_wfi_p2p_rx(struct wilc_vif *vif, u8 *buff, u32 size)
--
2.25.1

2022-08-29 12:50:11

by Ammar Faizi

Subject: Re: [PATCH linux-next] wifi: cfg80211: remove redundant ret variable

On Mon, Aug 29, 2022 at 6:35 PM <[email protected]> wrote:
> From: Jinpeng Cui <[email protected]>
>
> Return value from cfg80211_rx_mgmt() directly instead of
> taking this in another redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Jinpeng Cui <[email protected]>

Reviewed-by: Ammar Faizi <[email protected]>

2022-08-29 16:16:42

by Kalle Valo

Subject: Re: [PATCH linux-next] wifi: cfg80211: remove redundant ret variable

[email protected] writes:

> From: Jinpeng Cui <[email protected]>
>
> Return value from cfg80211_rx_mgmt() directly instead of
> taking this in another redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Jinpeng Cui <[email protected]>
> ---
> drivers/net/wireless/microchip/wilc1000/cfg80211.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)

The title should be:

wifi: wilc1000: remove redundant ret variable

Please read our documentation:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches