2022-10-31 16:43:23

by Shayne Chen

[permalink] [raw]
Subject: [PATCH 08/10] wifi: mt76: connac: add more starec command tags

Add starec tags which will be used in new chipset.
This is a preliminary patch to add mt7996 chipset support.

Signed-off-by: Shayne Chen <[email protected]>
---
drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
index ed1d24822c37..336c20fcc8dc 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
+++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
@@ -791,6 +791,8 @@ enum {
STA_REC_PHY = 0x15,
STA_REC_HE_6G = 0x17,
STA_REC_HE_V2 = 0x19,
+ STA_REC_HDRT = 0x28,
+ STA_REC_HDR_TRANS = 0x2B,
STA_REC_MAX_NUM
};

--
2.25.1



2022-11-09 12:16:23

by Lorenzo Bianconi

[permalink] [raw]
Subject: Re: [PATCH 08/10] wifi: mt76: connac: add more starec command tags

> Add starec tags which will be used in new chipset.
> This is a preliminary patch to add mt7996 chipset support.
>
> Signed-off-by: Shayne Chen <[email protected]>
> ---
> drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> index ed1d24822c37..336c20fcc8dc 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> @@ -791,6 +791,8 @@ enum {
> STA_REC_PHY = 0x15,
> STA_REC_HE_6G = 0x17,
> STA_REC_HE_V2 = 0x19,
> + STA_REC_HDRT = 0x28,
> + STA_REC_HDR_TRANS = 0x2B,
> STA_REC_MAX_NUM
> };

I guess this patch does not apply cleanly.

Regards,
Lorenzo

>
> --
> 2.25.1
>

Attachments:
(No filename) (868.00 B)
 signature.asc (235.00 B)
 Download all attachments

2022-11-09 12:23:59

by Lorenzo Bianconi

[permalink] [raw]
Subject: Re: [PATCH 08/10] wifi: mt76: connac: add more starec command tags

> > Add starec tags which will be used in new chipset.
> > This is a preliminary patch to add mt7996 chipset support.
> >
> > Signed-off-by: Shayne Chen <[email protected]>
> > ---
> > drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> > index ed1d24822c37..336c20fcc8dc 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> > +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> > @@ -791,6 +791,8 @@ enum {
> > STA_REC_PHY = 0x15,
> > STA_REC_HE_6G = 0x17,
> > STA_REC_HE_V2 = 0x19,
> > + STA_REC_HDRT = 0x28,
> > + STA_REC_HDR_TRANS = 0x2B,
> > STA_REC_MAX_NUM
> > };
>
> I guess this patch does not apply cleanly.
>
> Regards,
> Lorenzo
>
> >
> > --
> > 2.25.1
> >

I guess I am missing sta_rec_he_v2 structure definition. Is it already upstream
or have you missed it?

Regards,
Lorenzo

Attachments:
(No filename) (1.03 kB)
 signature.asc (235.00 B)
 Download all attachments

2022-11-09 12:56:13

by Shayne Chen

[permalink] [raw]
Subject: Re: [PATCH 08/10] wifi: mt76: connac: add more starec command tags

On Wed, 2022-11-09 at 13:23 +0100, Lorenzo Bianconi wrote:
> > > Add starec tags which will be used in new chipset.
> > > This is a preliminary patch to add mt7996 chipset support.
> > >
> > > Signed-off-by: Shayne Chen <[email protected]>
> > > ---
> > > drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> > > b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> > > index ed1d24822c37..336c20fcc8dc 100644
> > > --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> > > +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> > > @@ -791,6 +791,8 @@ enum {
> > > STA_REC_PHY = 0x15,
> > > STA_REC_HE_6G = 0x17,
> > > STA_REC_HE_V2 = 0x19,
> > > + STA_REC_HDRT = 0x28,
> > > + STA_REC_HDR_TRANS = 0x2B,
> > > STA_REC_MAX_NUM
> > > };
> >
> > I guess this patch does not apply cleanly.
> >
> > Regards,
> > Lorenzo
> >
Hi Lore,

The series is already rebased on top of this patch:

https://patchwork.kernel.org/project/linux-wireless/patch/85b5e8374fc9b86fb955060c1840f3b2a1d187e4.1666614616.git.deren.wu@mediatek.com/

I'll mention this in v2.

Thanks,
Shayne
> > >
> > > --
> > > 2.25.1
> > >
>
> I guess I am missing sta_rec_he_v2 structure definition. Is it
> already upstream
> or have you missed it?
>
> Regards,
> Lorenzo