2023-02-07 13:35:17

by Frank Wunderlich

[permalink] [raw]
Subject: [PATCH v2] dt-bindings: mt76: add active-low property for led

From: Frank Wunderlich <[email protected]>

LEDs can be in low-active mode, driver already supports it, but
documentation is missing. Add documentation for the dt property.

Signed-off-by: Frank Wunderlich <[email protected]>
---
v2:
- change commit message to mention that driver already support this
---
.../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
index f0c78f994491..212508672979 100644
--- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
@@ -112,6 +112,11 @@ properties:
$ref: /schemas/leds/common.yaml#
additionalProperties: false
properties:
+ led-active-low:
+ description:
+ LED is enabled with ground signal.
+ type: boolean
+
led-sources:
maxItems: 1

--
2.34.1



2023-02-07 13:36:12

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2] dt-bindings: mt76: add active-low property for led

On 07/02/2023 14:35, Frank Wunderlich wrote:
> From: Frank Wunderlich <[email protected]>
>
> LEDs can be in low-active mode, driver already supports it, but
> documentation is missing. Add documentation for the dt property.
>
> Signed-off-by: Frank Wunderlich <[email protected]>\


Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof


2023-03-30 17:20:47

by Matthias Brugger

[permalink] [raw]
Subject: Re: [PATCH v2] dt-bindings: mt76: add active-low property for led

Hi Felix and Kalle,

On 07/02/2023 14:36, Krzysztof Kozlowski wrote:
> On 07/02/2023 14:35, Frank Wunderlich wrote:
>> From: Frank Wunderlich <[email protected]>
>>
>> LEDs can be in low-active mode, driver already supports it, but
>> documentation is missing. Add documentation for the dt property.
>>
>> Signed-off-by: Frank Wunderlich <[email protected]>\
>
>
> Acked-by: Krzysztof Kozlowski <[email protected]>
>

Can you take that through your tree or are fine if I take it through mine?

Regards,
Matthias

2023-03-31 14:26:46

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH v2] dt-bindings: mt76: add active-low property for led

Matthias Brugger <[email protected]> writes:

> On 07/02/2023 14:36, Krzysztof Kozlowski wrote:
>> On 07/02/2023 14:35, Frank Wunderlich wrote:
>>> From: Frank Wunderlich <[email protected]>
>>>
>>> LEDs can be in low-active mode, driver already supports it, but
>>> documentation is missing. Add documentation for the dt property.
>>>
>>> Signed-off-by: Frank Wunderlich <[email protected]>\
>>
>>
>> Acked-by: Krzysztof Kozlowski <[email protected]>
>>
>
> Can you take that through your tree or are fine if I take it through mine?

It would be safest if Felix can take this to his tree, less conflicts
the better.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches