2023-04-30 17:18:30

by Larry Finger

[permalink] [raw]
Subject: [PATCH] wifi: rtl8xxxu: Remove CONFIG_RTL8XXXU_UNTESTED

This parameter is selected by openSUSE, Fedora, Ubuntu, and Mint. Of the
distros that I checked, only Debian on ppc32 did not select it.
Eliminating this option will have little effect on Linux users, and is a
necessary step in the elimination of the old rtl8192cu driver in the
rtlwifi family.

Signed-off-by: Larry Finger <[email protected]>
---
drivers/net/wireless/realtek/rtl8xxxu/Kconfig | 10 ----------
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192c.c | 2 --
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 3 ---
3 files changed, 15 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtl8xxxu/Kconfig b/drivers/net/wireless/realtek/rtl8xxxu/Kconfig
index 82bcaf44a65f..7989064c863b 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/Kconfig
+++ b/drivers/net/wireless/realtek/rtl8xxxu/Kconfig
@@ -25,13 +25,3 @@ config RTL8XXXU

To compile this driver as a module, choose M here: the module will
be called rtl8xxxu. If unsure, say N.
-
-config RTL8XXXU_UNTESTED
- bool "Include support for untested Realtek 8xxx USB devices (EXPERIMENTAL)"
- depends on RTL8XXXU
- help
- This option enables detection of Realtek 8723/8188/8191/8192 WiFi
- USB devices which have not been tested directly by the driver
- author or reported to be working by third parties.
-
- Please report your results!
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192c.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192c.c
index b30a9a513cb8..ff0917ba2744 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192c.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192c.c
@@ -32,7 +32,6 @@
#include "rtl8xxxu.h"
#include "rtl8xxxu_regs.h"

-#ifdef CONFIG_RTL8XXXU_UNTESTED
static struct rtl8xxxu_power_base rtl8192c_power_base = {
.reg_0e00 = 0x07090c0c,
.reg_0e04 = 0x01020405,
@@ -626,4 +625,3 @@ struct rtl8xxxu_fileops rtl8192cu_fops = {
.page_num_lo = TX_PAGE_NUM_LO_PQ,
.page_num_norm = TX_PAGE_NUM_NORM_PQ,
};
-#endif
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
index fd8c8c6d53d6..4b4976a00fd2 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
@@ -7523,8 +7523,6 @@ static const struct usb_device_id dev_table[] = {
/* TOTOLINK N150UA V5 / N150UA-B */
{USB_DEVICE_AND_INTERFACE_INFO(USB_VENDOR_ID_REALTEK, 0x2005, 0xff, 0xff, 0xff),
.driver_info = (unsigned long)&rtl8710bu_fops},
-#ifdef CONFIG_RTL8XXXU_UNTESTED
-/* Still supported by rtlwifi */
{USB_DEVICE_AND_INTERFACE_INFO(USB_VENDOR_ID_REALTEK, 0x8176, 0xff, 0xff, 0xff),
.driver_info = (unsigned long)&rtl8192cu_fops},
{USB_DEVICE_AND_INTERFACE_INFO(USB_VENDOR_ID_REALTEK, 0x8178, 0xff, 0xff, 0xff),
@@ -7678,7 +7676,6 @@ static const struct usb_device_id dev_table[] = {
.driver_info = (unsigned long)&rtl8192eu_fops},
{USB_DEVICE_AND_INTERFACE_INFO(USB_VENDOR_ID_REALTEK, 0x818c, 0xff, 0xff, 0xff),
.driver_info = (unsigned long)&rtl8192eu_fops},
-#endif
{ }
};

--
2.40.1


2023-05-12 08:28:11

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] wifi: rtl8xxxu: Remove CONFIG_RTL8XXXU_UNTESTED

Larry Finger <[email protected]> wrote:

> This parameter is selected by openSUSE, Fedora, Ubuntu, and Mint. Of the
> distros that I checked, only Debian on ppc32 did not select it.
> Eliminating this option will have little effect on Linux users, and is a
> necessary step in the elimination of the old rtl8192cu driver in the
> rtlwifi family.
>
> Signed-off-by: Larry Finger <[email protected]>

Dropping per discussion in:

https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

Patch set to Changes Requested.

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches