Change crash logging from debug to informational and add warning when
firmware crash MHI_CB_EE_RDDM happens.
Tested-on: Qualcomm WCN6855
Signed-off-by: Arowa Suliman <[email protected]>
---
drivers/net/wireless/ath/ath11k/mhi.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/mhi.c b/drivers/net/wireless/ath/ath11k/mhi.c
index 3ac689f1def4..fb203e7c962b 100644
--- a/drivers/net/wireless/ath/ath11k/mhi.c
+++ b/drivers/net/wireless/ath/ath11k/mhi.c
@@ -325,7 +325,7 @@ static void ath11k_mhi_op_status_cb(struct mhi_controller *mhi_cntrl,
{
struct ath11k_base *ab = dev_get_drvdata(mhi_cntrl->cntrl_dev);
- ath11k_dbg(ab, ATH11K_DBG_BOOT, "notify status reason %s\n",
+ ath11k_info(ab, ATH11K_DBG_BOOT, "notify status reason %s\n",
ath11k_mhi_op_callback_to_str(cb));
switch (cb) {
@@ -333,7 +333,8 @@ static void ath11k_mhi_op_status_cb(struct mhi_controller *mhi_cntrl,
ath11k_warn(ab, "firmware crashed: MHI_CB_SYS_ERROR\n");
break;
case MHI_CB_EE_RDDM:
- if (!(test_bit(ATH11K_FLAG_UNREGISTERING, &ab->dev_flags)))
+ ath11k_warn(ab, "firmware crashed: MHI_CB_EE_RDDM\n");
+ if (!(test_bit(ATH11K_FLAG_UNREGISTERING, &ab->dev_flags)))
queue_work(ab->workqueue_aux, &ab->reset_work);
break;
default:
--
2.41.0.162.gfafddb0af9-goog
Hi Arowa,
kernel test robot noticed the following build warnings:
[auto build test WARNING on kvalo-ath/ath-next]
[cannot apply to wireless/main wireless-next/main linus/master v6.4-rc6 next-20230613]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Arowa-Suliman/wifi-ath11k-Add-crash-logging/20230614-103201
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next
patch link: https://lore.kernel.org/r/20230614023125.284218-1-arowa%40google.com
patch subject: [PATCH] wifi: ath11k: Add crash logging
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20230614/[email protected]/config)
compiler: alpha-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
mkdir -p ~/bin
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add kvalo-ath https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git
git fetch kvalo-ath ath-next
git checkout kvalo-ath/ath-next
b4 shazam https://lore.kernel.org/r/[email protected]
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=alpha olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash drivers/net/
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All warnings (new ones prefixed by >>):
drivers/net/wireless/ath/ath11k/mhi.c: In function 'ath11k_mhi_op_status_cb':
>> drivers/net/wireless/ath/ath11k/mhi.c:328:25: warning: passing argument 2 of 'ath11k_info' makes pointer from integer without a cast [-Wint-conversion]
328 | ath11k_info(ab, ATH11K_DBG_BOOT, "notify status reason %s\n",
| ^~~~~~~~~~~~~~~
| |
| int
In file included from drivers/net/wireless/ath/ath11k/mhi.c:14:
drivers/net/wireless/ath/ath11k/debug.h:76:69: note: expected 'const char *' but argument is of type 'int'
76 | __printf(2, 3) void ath11k_info(struct ath11k_base *ab, const char *fmt, ...);
| ~~~~~~~~~~~~^~~
vim +/ath11k_info +328 drivers/net/wireless/ath/ath11k/mhi.c
322
323 static void ath11k_mhi_op_status_cb(struct mhi_controller *mhi_cntrl,
324 enum mhi_callback cb)
325 {
326 struct ath11k_base *ab = dev_get_drvdata(mhi_cntrl->cntrl_dev);
327
> 328 ath11k_info(ab, ATH11K_DBG_BOOT, "notify status reason %s\n",
329 ath11k_mhi_op_callback_to_str(cb));
330
331 switch (cb) {
332 case MHI_CB_SYS_ERROR:
333 ath11k_warn(ab, "firmware crashed: MHI_CB_SYS_ERROR\n");
334 break;
335 case MHI_CB_EE_RDDM:
336 ath11k_warn(ab, "firmware crashed: MHI_CB_EE_RDDM\n");
337 if (!(test_bit(ATH11K_FLAG_UNREGISTERING, &ab->dev_flags)))
338 queue_work(ab->workqueue_aux, &ab->reset_work);
339 break;
340 default:
341 break;
342 }
343 }
344
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki