2023-06-30 13:14:45

by Dongliang Mu

Subject: [PATCH] wifi: ath9k: fix printk specifier

Smatch reports:

ath_pci_probe() warn: argument 4 to %lx specifier is cast from pointer
ath_ahb_probe() warn: argument 4 to %lx specifier is cast from pointer

Fix it by modifying %lx to %px in printk.

Signed-off-by: Dongliang Mu <[email protected]>
---
drivers/net/wireless/ath/ath9k/ahb.c | 4 ++--
drivers/net/wireless/ath/ath9k/pci.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/ahb.c b/drivers/net/wireless/ath/ath9k/ahb.c
index 9cd12b20b18d..a683757eecd4 100644
--- a/drivers/net/wireless/ath/ath9k/ahb.c
+++ b/drivers/net/wireless/ath/ath9k/ahb.c
@@ -132,8 +132,8 @@ static int ath_ahb_probe(struct platform_device *pdev)

ah = sc->sc_ah;
ath9k_hw_name(ah, hw_name, sizeof(hw_name));
- wiphy_info(hw->wiphy, "%s mem=0x%lx, irq=%d\n",
- hw_name, (unsigned long)mem, irq);
+ wiphy_info(hw->wiphy, "%s mem=0x%p, irq=%d\n",
+ hw_name, mem, irq);

return 0;

diff --git a/drivers/net/wireless/ath/ath9k/pci.c b/drivers/net/wireless/ath/ath9k/pci.c
index a09f9d223f3d..12c00c7c1408 100644
--- a/drivers/net/wireless/ath/ath9k/pci.c
+++ b/drivers/net/wireless/ath/ath9k/pci.c
@@ -988,8 +988,8 @@ static int ath_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
sc->sc_ah->msi_reg = 0;

ath9k_hw_name(sc->sc_ah, hw_name, sizeof(hw_name));
- wiphy_info(hw->wiphy, "%s mem=0x%lx, irq=%d\n",
- hw_name, (unsigned long)sc->mem, pdev->irq);
+ wiphy_info(hw->wiphy, "%s mem=0x%p, irq=%d\n",
+ hw_name, sc->mem, pdev->irq);

return 0;

--
2.34.1

2023-07-05 21:21:35

by Jakub Kicinski

Subject: Re: [PATCH] wifi: ath9k: fix printk specifier

On Fri, 30 Jun 2023 21:03:02 +0800 Dongliang Mu wrote:
> Smatch reports:
>
> ath_pci_probe() warn: argument 4 to %lx specifier is cast from pointer
> ath_ahb_probe() warn: argument 4 to %lx specifier is cast from pointer
>
> Fix it by modifying %lx to %px in printk.

The patch does %p not %px.

2023-07-06 00:50:10

by Dongliang Mu

Subject: Re: [PATCH] wifi: ath9k: fix printk specifier

On 7/6/23 05:15, Jakub Kicinski wrote:
> On Fri, 30 Jun 2023 21:03:02 +0800 Dongliang Mu wrote:
>> Smatch reports:
>>
>> ath_pci_probe() warn: argument 4 to %lx specifier is cast from pointer
>> ath_ahb_probe() warn: argument 4 to %lx specifier is cast from pointer
>>
>> Fix it by modifying %lx to %px in printk.
> The patch does %p not %px.

Yes, checkpatch.pl suggests %p other than %px. So I revise it to %p, but
forget to modify the commit message.

I will submit a v2 patch.