2023-07-06 09:56:44

by Johannes Wiesboeck

Subject: [PATCH] wifi: mwifiex: Set WIPHY_FLAG_NETNS_OK flag

Allow moving the wiphy device for mwififex to a non-inital network
namespace. Many wireless drivers enable this flag implicitly by
initializing through the generic ieee80211_alloc_hw_nm function. As
mwifiex does not utilize this function WIPHY_FLAG_NETNS_OK must be set
explicitly.

Moving to network namespace and working connection tested using
wpa_supplicant from a network namespace as well as from a container on
GyroidOS. The hardware was the Toradex Apalis i.MX8QM Board using the
Azurewave AW-CM276NF wireless module.

Signed-off-by: Johannes Wiesboeck <[email protected]>
Reviewed-by: Michael Weiß <[email protected]>
---
drivers/net/wireless/marvell/mwifiex/cfg80211.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
index 813d1cbebe19b..ba4e29713a8c9 100644
--- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
+++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
@@ -4395,6 +4395,7 @@ int mwifiex_register_cfg80211(struct mwifiex_adapter *adapter)
WIPHY_FLAG_AP_UAPSD |
WIPHY_FLAG_HAS_REMAIN_ON_CHANNEL |
WIPHY_FLAG_HAS_CHANNEL_SWITCH |
+ WIPHY_FLAG_NETNS_OK |
WIPHY_FLAG_PS_ON_BY_DEFAULT;

if (ISSUPP_TDLS_ENABLED(adapter->fw_cap_info))
--
2.41.0

2023-07-25 15:36:51

by Kalle Valo

Subject: Re: [PATCH] wifi: mwifiex: Set WIPHY_FLAG_NETNS_OK flag

Johannes Wiesboeck <[email protected]> wrote:

> Allow moving the wiphy device for mwififex to a non-inital network
> namespace. Many wireless drivers enable this flag implicitly by
> initializing through the generic ieee80211_alloc_hw_nm function. As
> mwifiex does not utilize this function WIPHY_FLAG_NETNS_OK must be set
> explicitly.
>
> Moving to network namespace and working connection tested using
> wpa_supplicant from a network namespace as well as from a container on
> GyroidOS. The hardware was the Toradex Apalis i.MX8QM Board using the
> Azurewave AW-CM276NF wireless module.
>
> Signed-off-by: Johannes Wiesboeck <[email protected]>
> Reviewed-by: Michael Weiß <[email protected]>

Patch applied to wireless-next.git, thanks.

7ee92f6b4160 wifi: mwifiex: Set WIPHY_FLAG_NETNS_OK flag

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches