2023-07-26 11:30:09

by Wang Ming

Subject: [PATCH net-next v4] wifi: ath6kl: Remove error checking for debugfs_create_dir()

It is expected that most callers should _ignore_ the errors
return by debugfs_create_dir() in ath6kl_debug_init_fs().

Signed-off-by: Wang Ming <[email protected]>
---
drivers/net/wireless/ath/ath6kl/debug.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath6kl/debug.c b/drivers/net/wireless/ath/ath6kl/debug.c
index 433a047f3747..b837d31416df 100644
--- a/drivers/net/wireless/ath/ath6kl/debug.c
+++ b/drivers/net/wireless/ath/ath6kl/debug.c
@@ -1793,8 +1793,6 @@ int ath6kl_debug_init_fs(struct ath6kl *ar)
{
ar->debugfs_phy = debugfs_create_dir("ath6kl",
ar->wiphy->debugfsdir);
- if (!ar->debugfs_phy)
- return -ENOMEM;

debugfs_create_file("tgt_stats", 0400, ar->debugfs_phy, ar,
&fops_tgt_stats);
--
2.25.1

2023-08-02 18:49:36

by Kalle Valo

Subject: Re: [PATCH net-next v4] wifi: ath6kl: Remove error checking for debugfs_create_dir()

Wang Ming <[email protected]> wrote:

> It is expected that most callers should _ignore_ the errors
> return by debugfs_create_dir() in ath6kl_debug_init_fs().
>
> Signed-off-by: Wang Ming <[email protected]>

This has been already applied:
https://git.kernel.org/kvalo/ath/c/1301783c8def

Patch set to Superseded.

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches