2023-08-01 14:12:23

by Yue Haibing

[permalink] [raw]
Subject: [PATCH] wifi: mac80211: Remove unused function declarations

Commit 685429623f88 ("mac80211: Fix circular locking dependency in ARP filter handling")
leave ieee80211_set_arp_filter() declaration unused.
And 164eb02d070a ("mac80211: add radar detection command/event") introducted
ieee80211_dfs_cac_timer() declaration but never implemented.

Signed-off-by: Yue Haibing <[email protected]>
---
net/mac80211/ieee80211_i.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h
index 91633a0b723e..06bd406846d2 100644
--- a/net/mac80211/ieee80211_i.h
+++ b/net/mac80211/ieee80211_i.h
@@ -1872,7 +1872,6 @@ void ieee80211_send_pspoll(struct ieee80211_local *local,
struct ieee80211_sub_if_data *sdata);
void ieee80211_recalc_ps(struct ieee80211_local *local);
void ieee80211_recalc_ps_vif(struct ieee80211_sub_if_data *sdata);
-int ieee80211_set_arp_filter(struct ieee80211_sub_if_data *sdata);
void ieee80211_sta_work(struct ieee80211_sub_if_data *sdata);
void ieee80211_sta_rx_queued_mgmt(struct ieee80211_sub_if_data *sdata,
struct sk_buff *skb);
@@ -2564,7 +2563,6 @@ void ieee80211_recalc_chanctx_min_def(struct ieee80211_local *local,
struct ieee80211_link_data *rsvd_for);
bool ieee80211_is_radar_required(struct ieee80211_local *local);

-void ieee80211_dfs_cac_timer(unsigned long data);
void ieee80211_dfs_cac_timer_work(struct work_struct *work);
void ieee80211_dfs_cac_cancel(struct ieee80211_local *local);
void ieee80211_dfs_radar_detected_work(struct work_struct *work);
--
2.34.1



2023-08-02 09:12:46

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH] wifi: mac80211: Remove unused function declarations

On Tue, Aug 01, 2023 at 09:43:37PM +0800, Yue Haibing wrote:
> Commit 685429623f88 ("mac80211: Fix circular locking dependency in ARP filter handling")
> leave ieee80211_set_arp_filter() declaration unused.
> And 164eb02d070a ("mac80211: add radar detection command/event") introducted
> ieee80211_dfs_cac_timer() declaration but never implemented.
>
> Signed-off-by: Yue Haibing <[email protected]>

Reviewed-by: Simon Horman <[email protected]>