2023-08-03 07:40:12

by Wu Yunchuan

Subject: [PATCH net-next v2 1/9] wifi: rsi: rsi_91x_coex: Remove unnecessary (void*) conversions

No need cast (void*) to (struct rsi_coex_ctrl_block *) or
(struct rsi_common *).

Signed-off-by: Wu Yunchuan <[email protected]>
---
drivers/net/wireless/rsi/rsi_91x_coex.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/net/wireless/rsi/rsi_91x_coex.c b/drivers/net/wireless/rsi/rsi_91x_coex.c
index 45ac9371f262..372eaaa2b9ef 100644
--- a/drivers/net/wireless/rsi/rsi_91x_coex.c
+++ b/drivers/net/wireless/rsi/rsi_91x_coex.c
@@ -52,8 +52,7 @@ static void rsi_coex_sched_tx_pkts(struct rsi_coex_ctrl_block *coex_cb)

static void rsi_coex_scheduler_thread(struct rsi_common *common)
{
- struct rsi_coex_ctrl_block *coex_cb =
- (struct rsi_coex_ctrl_block *)common->coex_cb;
+ struct rsi_coex_ctrl_block *coex_cb = common->coex_cb;
u32 timeout = EVENT_WAIT_FOREVER;

do {
@@ -100,9 +99,8 @@ static inline int rsi_map_coex_q(u8 hal_queue)

int rsi_coex_send_pkt(void *priv, struct sk_buff *skb, u8 hal_queue)
{
- struct rsi_common *common = (struct rsi_common *)priv;
- struct rsi_coex_ctrl_block *coex_cb =
- (struct rsi_coex_ctrl_block *)common->coex_cb;
+ struct rsi_common *common = priv;
+ struct rsi_coex_ctrl_block *coex_cb = common->coex_cb;
struct skb_info *tx_params = NULL;
enum rsi_coex_queues coex_q;
int status;
@@ -168,8 +166,7 @@ int rsi_coex_attach(struct rsi_common *common)

void rsi_coex_detach(struct rsi_common *common)
{
- struct rsi_coex_ctrl_block *coex_cb =
- (struct rsi_coex_ctrl_block *)common->coex_cb;
+ struct rsi_coex_ctrl_block *coex_cb = common->coex_cb;
int cnt;

rsi_kill_thread(&coex_cb->coex_tx_thread);
--
2.30.2

2023-08-23 15:45:35

by Kalle Valo

Subject: Re: [PATCH net-next v2 1/9] wifi: rsi: rsi_91x_coex: Remove unnecessary (void*) conversions

Wu Yunchuan <[email protected]> wrote:

> No need cast (void*) to (struct rsi_coex_ctrl_block *) or
> (struct rsi_common *).
>
> Signed-off-by: Wu Yunchuan <[email protected]>

9 patches applied to wireless-next.git, thanks.

5f48e91624b3 wifi: rsi: rsi_91x_coex: Remove unnecessary (void*) conversions
148924e537df wifi: rsi: rsi_91x_debugfs: Remove unnecessary (void*) conversions
52424e0c49d6 wifi: rsi: rsi_91x_hal: Remove unnecessary conversions
6d5d2dbd00bf wifi: rsi: rsi_91x_mac80211: Remove unnecessary conversions
db2be1a01fc5 wifi: rsi: rsi_91x_main: Remove unnecessary (void*) conversions
f9bf6e729f4e wifi: rsi: rsi_91x_sdio: Remove unnecessary (void*) conversions
361beddbfb7c wifi: rsi: rsi_91x_sdio_ops: Remove unnecessary (void*) conversions
f543235c3948 wifi: rsi: rsi_91x_usb: Remove unnecessary (void*) conversions
7d8473c799be wifi: rsi: rsi_91x_usb_ops: Remove unnecessary (void*) conversions

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches