From: Po-Hao Huang <[email protected]>
The probe function of 8822cu is misplaced to 8822bu, so we fix it.
Fixes: 07cef03b8d44 ("wifi: rtw88: Add rtw8822cu chipset support")
Signed-off-by: Po-Hao Huang <[email protected]>
Signed-off-by: Ping-Ke Shih <[email protected]>
---
drivers/net/wireless/realtek/rtw88/rtw8822cu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822cu.c b/drivers/net/wireless/realtek/rtw88/rtw8822cu.c
index af28ca09d41f..157d5102a4b1 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8822cu.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8822cu.c
@@ -25,7 +25,7 @@ static const struct usb_device_id rtw_8822cu_id_table[] = {
};
MODULE_DEVICE_TABLE(usb, rtw_8822cu_id_table);
-static int rtw8822bu_probe(struct usb_interface *intf,
+static int rtw8822cu_probe(struct usb_interface *intf,
const struct usb_device_id *id)
{
return rtw_usb_probe(intf, id);
@@ -34,7 +34,7 @@ static int rtw8822bu_probe(struct usb_interface *intf,
static struct usb_driver rtw_8822cu_driver = {
.name = "rtw_8822cu",
.id_table = rtw_8822cu_id_table,
- .probe = rtw8822bu_probe,
+ .probe = rtw8822cu_probe,
.disconnect = rtw_usb_disconnect,
};
module_usb_driver(rtw_8822cu_driver);
--
2.25.1
Ping-Ke Shih <[email protected]> writes:
> From: Po-Hao Huang <[email protected]>
>
> The probe function of 8822cu is misplaced to 8822bu, so we fix it.
>
> Fixes: 07cef03b8d44 ("wifi: rtw88: Add rtw8822cu chipset support")
> Signed-off-by: Po-Hao Huang <[email protected]>
> Signed-off-by: Ping-Ke Shih <[email protected]>
I guess this is just a cosmetic change and does not cause any changes in
functionality? I can add that to the commit log.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
> -----Original Message-----
> From: Kalle Valo <[email protected]>
> Sent: Friday, August 25, 2023 2:47 PM
> To: Ping-Ke Shih <[email protected]>
> Cc: Bernie Huang <[email protected]>; [email protected]
> Subject: Re: [PATCH] wifi: rtw88: fix typo rtw8822cu_probe
>
> Ping-Ke Shih <[email protected]> writes:
>
> > From: Po-Hao Huang <[email protected]>
> >
> > The probe function of 8822cu is misplaced to 8822bu, so we fix it.
> >
> > Fixes: 07cef03b8d44 ("wifi: rtw88: Add rtw8822cu chipset support")
> > Signed-off-by: Po-Hao Huang <[email protected]>
> > Signed-off-by: Ping-Ke Shih <[email protected]>
>
> I guess this is just a cosmetic change and does not cause any changes in
> functionality? I can add that to the commit log.
>
Yes, it doesn't change anything. If Fixes tag is not suitable, please also
remove it.
Thank you.
Ping-ke
Ping-Ke Shih <[email protected]> writes:
>> -----Original Message-----
>> From: Kalle Valo <[email protected]>
>> Sent: Friday, August 25, 2023 2:47 PM
>> To: Ping-Ke Shih <[email protected]>
>> Cc: Bernie Huang <[email protected]>; [email protected]
>> Subject: Re: [PATCH] wifi: rtw88: fix typo rtw8822cu_probe
>>
>> Ping-Ke Shih <[email protected]> writes:
>>
>> > From: Po-Hao Huang <[email protected]>
>> >
>> > The probe function of 8822cu is misplaced to 8822bu, so we fix it.
>> >
>> > Fixes: 07cef03b8d44 ("wifi: rtw88: Add rtw8822cu chipset support")
>> > Signed-off-by: Po-Hao Huang <[email protected]>
>> > Signed-off-by: Ping-Ke Shih <[email protected]>
>>
>> I guess this is just a cosmetic change and does not cause any changes in
>> functionality? I can add that to the commit log.
>
> Yes, it doesn't change anything. If Fixes tag is not suitable, please also
> remove it.
Good point, as this is not fixing any functionality in opinion there
should not be a Fixes tag. I'll also remove that.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Ping-Ke Shih <[email protected]> wrote:
> From: Po-Hao Huang <[email protected]>
>
> The probe function of 8822cu is misplaced to 8822bu, so we fix it. Just
> cosmetics, no changes in functionality.
>
> Signed-off-by: Po-Hao Huang <[email protected]>
> Signed-off-by: Ping-Ke Shih <[email protected]>
Patch applied to wireless-next.git, thanks.
497840a1fc5c wifi: rtw88: fix typo rtw8822cu_probe
--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches