2023-10-13 01:12:09

by Ping-Ke Shih

[permalink] [raw]
Subject: RE: [PATCH 1/1] wifi: rtw88: 8822b: disable call trace when write RF mode table fail



> -----Original Message-----
> From: Chukun Pan <[email protected]>
> Sent: Thursday, October 12, 2023 10:01 PM
> To: Ping-Ke Shih <[email protected]>
> Cc: Kalle Valo <[email protected]>; [email protected]; [email protected]; Chukun
> Pan <[email protected]>
> Subject: [PATCH 1/1] wifi: rtw88: 8822b: disable call trace when write RF mode table fail
>
> The rtw88 driver throws a useless Call Trace when the rtl8812bu
> or rtl8822be wifi modules fail to write the RF mode table.

Why do you think this trace is useless? As I see, there is more than one callers.
Did you meet a real case it throws this trace? If yes, how about the frequency?

Ping-Ke


2023-10-13 02:39:39

by Chukun Pan

[permalink] [raw]
Subject: RE: [PATCH 1/1] wifi: rtw88: 8822b: disable call trace when write RF mode table fail

Hi, Ping-Ke

> Why do you think this trace is useless? As I see, there is more than one callers.
> Did you meet a real case it throws this trace? If yes, how about the frequency?

[ 217.651858] ------------[ cut here ]------------
[ 217.654813] write RF mode table fail
[ 217.657434] WARNING: CPU: 2 PID: 3705 at 0xffffffffa03df3cb [rtw88_8822b@00000000bf0fde9e+0x35000]
[ 217.662078] Modules linked in: rtw88_8822ce rtw88_8822c rtw88_8822be rtw88_8822b rtw88_8723de ...
[ 217.704412] RIP: 0010:0xffffffffa03df3cb [rtw88_8822b@00000000bf0fde9e+0x35000]
...
[ 217.737232] Call Trace:
[ 217.738683] 0xffffffffa03df943 [rtw88_8822b@00000000bf0fde9e+0x35000]
[ 217.740865] 0xffffffffa0385ab9 [rtw88_core@00000000a8d26f0d+0x1a000]
[ 217.742993] 0xffffffffa0279111 [mac80211@000000003cb4b3bd+0x7b000]
[ 217.745028] 0xffffffffa0239092 [cfg80211@00000000a951c4b5+0x46000]
[ 217.751368] ? 0xffffffffa0238de0 [cfg80211@00000000a951c4b5+0x46000]
[ 217.773278] RIP: 0033:0x7ff0cdf8836c
...
[ 217.789457] ---[ end trace 177712424e9eab4a ]---

As you can see this trace above, I don't think it's useful. This
trace throws up a lot of register values but doesn't point out why.
As long as I plug in the rtl8812bu or rtl8822be wifi modules, this
trace will be thrown every time when the rtw88 driver is loaded.

Thanks,
Chukun

--
2.25.1

2023-10-13 04:21:20

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH 1/1] wifi: rtw88: 8822b: disable call trace when write RF mode table fail

Chukun Pan <[email protected]> writes:

> Hi, Ping-Ke
>
>> Why do you think this trace is useless? As I see, there is more than one callers.
>> Did you meet a real case it throws this trace? If yes, how about the frequency?
>
> [ 217.651858] ------------[ cut here ]------------
> [ 217.654813] write RF mode table fail
> [ 217.657434] WARNING: CPU: 2 PID: 3705 at 0xffffffffa03df3cb [rtw88_8822b@00000000bf0fde9e+0x35000]
> [ 217.662078] Modules linked in: rtw88_8822ce rtw88_8822c rtw88_8822be rtw88_8822b rtw88_8723de ...
> [ 217.704412] RIP: 0010:0xffffffffa03df3cb [rtw88_8822b@00000000bf0fde9e+0x35000]
> ...
> [ 217.737232] Call Trace:
> [ 217.738683] 0xffffffffa03df943 [rtw88_8822b@00000000bf0fde9e+0x35000]
> [ 217.740865] 0xffffffffa0385ab9 [rtw88_core@00000000a8d26f0d+0x1a000]
> [ 217.742993] 0xffffffffa0279111 [mac80211@000000003cb4b3bd+0x7b000]
> [ 217.745028] 0xffffffffa0239092 [cfg80211@00000000a951c4b5+0x46000]
> [ 217.751368] ? 0xffffffffa0238de0 [cfg80211@00000000a951c4b5+0x46000]
> [ 217.773278] RIP: 0033:0x7ff0cdf8836c
> ...
> [ 217.789457] ---[ end trace 177712424e9eab4a ]---
>
> As you can see this trace above, I don't think it's useful. This
> trace throws up a lot of register values but doesn't point out why.
> As long as I plug in the rtl8812bu or rtl8822be wifi modules, this
> trace will be thrown every time when the rtw88 driver is loaded.

_Why_ is that warning printed? Are your devices uncalibrated or are they
somehow else special?

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches