Both ath11k and ath12k define the following:
struct ieee80211_ops *ops;
This is being flagged by checkpatch.pl:
WARNING: struct ieee80211_ops should normally be const
But it turns out that in both cases this is unused, so remove it.
Signed-off-by: Jeff Johnson <[email protected]>
---
Jeff Johnson (2):
wifi: ath11k: Remove struct ath11k::ops
wifi: ath12k: Remove struct ath12k::ops
drivers/net/wireless/ath/ath11k/core.h | 1 -
drivers/net/wireless/ath/ath12k/core.h | 3 +--
2 files changed, 1 insertion(+), 3 deletions(-)
---
base-commit: ac2f43d3d34e52b0d388b4c573ff6bbac90235b9
change-id: 20231103-ath12k-remove-ieee80211_ops-160d865e9ea4
Currently struct ath11k defines the following member:
struct ieee80211_ops *ops;
This is being flagged by checkpatch.pl:
WARNING: struct ieee80211_ops should normally be const
The original plan was to add the const qualifier. However, it turns
out this is actually unused, so remove it.
No functional changes, compile tested only.
Signed-off-by: Jeff Johnson <[email protected]>
---
drivers/net/wireless/ath/ath11k/core.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/core.h b/drivers/net/wireless/ath/ath11k/core.h
index f12b606e2d2e..7e3b6779f4e9 100644
--- a/drivers/net/wireless/ath/ath11k/core.h
+++ b/drivers/net/wireless/ath/ath11k/core.h
@@ -599,7 +599,6 @@ struct ath11k {
struct ath11k_base *ab;
struct ath11k_pdev *pdev;
struct ieee80211_hw *hw;
- struct ieee80211_ops *ops;
struct ath11k_pdev_wmi *wmi;
struct ath11k_pdev_dp dp;
u8 mac_addr[ETH_ALEN];
--
2.42.0
Jeff Johnson <[email protected]> wrote:
> Currently struct ath11k defines the following member:
> struct ieee80211_ops *ops;
>
> This is being flagged by checkpatch.pl:
> WARNING: struct ieee80211_ops should normally be const
>
> The original plan was to add the const qualifier. However, it turns
> out this is actually unused, so remove it.
>
> No functional changes, compile tested only.
>
> Signed-off-by: Jeff Johnson <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>
2 patches applied to ath-next branch of ath.git, thanks.
199a78565cc2 wifi: ath11k: Remove struct ath11k::ops
3b6ec0409fe8 wifi: ath12k: Remove struct ath12k::ops
--
https://patchwork.kernel.org/project/linux-wireless/patch/20231106-ath12k-remove-ieee80211_ops-v1-1-d72cef1a855b@quicinc.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches