2023-12-04 09:12:22

by Peter Chiu

[permalink] [raw]
Subject: [PATCH v2] dt-bindings: net: wireless: mt76: add interrupts description for MT7986

The mt7986 can support four interrupts to distribute the interrupts
to different CPUs.

Signed-off-by: Peter Chiu <[email protected]>
---
v2: Change to use description instead of using items.
---
.../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
index 252207adbc54..933bc7bdda01 100644
--- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
@@ -38,7 +38,11 @@ properties:
MT7986 should contain 3 regions consys, dcm, and sku, in this order.

interrupts:
- maxItems: 1
+ minItems: 1
+ maxItems: 4
+ description:
+ MT7986 provides up to 4 interrupts including one primary interrupt and
+ three additional interrupts for ring 4, 5, and 19.

power-domains:
maxItems: 1
--
2.18.0



2023-12-08 16:27:40

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v2] dt-bindings: net: wireless: mt76: add interrupts description for MT7986

On Mon, Dec 04, 2023 at 05:11:56PM +0800, Peter Chiu wrote:
> The mt7986 can support four interrupts to distribute the interrupts
> to different CPUs.
>
> Signed-off-by: Peter Chiu <[email protected]>
> ---
> v2: Change to use description instead of using items.

Not what I said to do...

Let me spell it out:

interrupts:
minItems: 1
items:
- description: major interrupt for rings
- description: addditional interrupt for ring 19
- description: addditional interrupt for ring 4
- description: addditional interrupt for ring 5

if:
properties:
compatible:
contains:
enum:
- mediatek,mt7986-wmac
then:
properties:
interrupts:
minItems: 4
else:
properties:
interrupts:
maxItems: 1


If there are 4 interrupts then you should always have all 4. It's not
some OS config. However, as an ABI, you might want to allow 1. If so,
then the if/then should just have the 'maxItems: 1' restriction for the
compatibles which only have 1 interrupt in the h/w.

Rob