2023-12-13 04:36:06

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH] wifi: cfg80211: fix spelling & punctutation

Correct spelling and run-on sentences.

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Johannes Berg <[email protected]>
Cc: [email protected]
Cc: Kalle Valo <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: Eric Dumazet <[email protected]>
Cc: Jakub Kicinski <[email protected]>
Cc: Paolo Abeni <[email protected]>
---
include/net/cfg80211.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff -- a/include/net/cfg80211.h b/include/net/cfg80211.h
--- a/include/net/cfg80211.h
+++ b/include/net/cfg80211.h
@@ -52,7 +52,7 @@
* such wiphy can have zero, one, or many virtual interfaces associated with
* it, which need to be identified as such by pointing the network interface's
* @ieee80211_ptr pointer to a &struct wireless_dev which further describes
- * the wireless part of the interface, normally this struct is embedded in the
+ * the wireless part of the interface. Normally this struct is embedded in the
* network interface's private data area. Drivers can optionally allow creating
* or destroying virtual interfaces on the fly, but without at least one or the
* ability to create some the wireless device isn't useful.
@@ -2560,7 +2560,7 @@ struct cfg80211_scan_info {
* @short_ssid: short ssid to scan for
* @bssid: bssid to scan for
* @channel_idx: idx of the channel in the channel array in the scan request
- * which the above info relvant to
+ * which the above info is relevant to
* @unsolicited_probe: the AP transmits unsolicited probe response every 20 TU
* @short_ssid_valid: @short_ssid is valid and can be used
* @psc_no_listen: when set, and the channel is a PSC channel, no need to wait
@@ -7431,7 +7431,7 @@ void cfg80211_notify_new_peer_candidate(
* RFkill integration in cfg80211 is almost invisible to drivers,
* as cfg80211 automatically registers an rfkill instance for each
* wireless device it knows about. Soft kill is also translated
- * into disconnecting and turning all interfaces off, drivers are
+ * into disconnecting and turning all interfaces off. Drivers are
* expected to turn off the device when all interfaces are down.
*
* However, devices may have a hard RFkill line, in which case they
@@ -7479,7 +7479,7 @@ static inline void wiphy_rfkill_stop_pol
* the configuration mechanism.
*
* A driver supporting vendor commands must register them as an array
- * in struct wiphy, with handlers for each one, each command has an
+ * in struct wiphy, with handlers for each one. Each command has an
* OUI and sub command ID to identify it.
*
* Note that this feature should not be (ab)used to implement protocol
@@ -7643,7 +7643,7 @@ static inline void cfg80211_vendor_event
* interact with driver-specific tools to aid, for instance,
* factory programming.
*
- * This chapter describes how drivers interact with it, for more
+ * This chapter describes how drivers interact with it. For more
* information see the nl80211 book's chapter on it.
*/



2023-12-14 17:27:11

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH] wifi: cfg80211: fix spelling & punctutation

On Tue, Dec 12, 2023 at 08:35:58PM -0800, Randy Dunlap wrote:
> Correct spelling and run-on sentences.
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Johannes Berg <[email protected]>
> Cc: [email protected]
> Cc: Kalle Valo <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: Eric Dumazet <[email protected]>
> Cc: Jakub Kicinski <[email protected]>
> Cc: Paolo Abeni <[email protected]>

Thanks Randy,

These changes look correct to me.

FWIIW, codespell does not flag any non-false-positive spelling errors
both with and without this patch.

Reviewed-by: Simon Horman <[email protected]>

2023-12-14 17:29:56

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH] wifi: cfg80211: fix spelling & punctutation

On Thu, Dec 14, 2023 at 05:27:05PM +0000, Simon Horman wrote:
> On Tue, Dec 12, 2023 at 08:35:58PM -0800, Randy Dunlap wrote:
> > Correct spelling and run-on sentences.
> >
> > Signed-off-by: Randy Dunlap <[email protected]>
> > Cc: Johannes Berg <[email protected]>
> > Cc: [email protected]
> > Cc: Kalle Valo <[email protected]>
> > Cc: "David S. Miller" <[email protected]>
> > Cc: Eric Dumazet <[email protected]>
> > Cc: Jakub Kicinski <[email protected]>
> > Cc: Paolo Abeni <[email protected]>
>
> Thanks Randy,
>
> These changes look correct to me.
>
> FWIIW, codespell does not flag any non-false-positive spelling errors
> both with and without this patch.

Sorry, I misspoke there.

I now see that with this patch applied codespell no
longer flags any non-false-positive spelling errors
in this file. And that relevant is misspelt without this patch.

> Reviewed-by: Simon Horman <[email protected]>