2023-12-13 05:48:12

by Randy Dunlap

Subject: [PATCH] wifi: mac80211: rx.c: fix sentence grammar

Correct a run-on sentence by changing "," to ";".
Add a subject in one sentence.

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Johannes Berg <[email protected]>
Cc: Kalle Valo <[email protected]>
Cc: [email protected]
Cc: "David S. Miller" <[email protected]>
Cc: Eric Dumazet <[email protected]>
Cc: Jakub Kicinski <[email protected]>
Cc: Paolo Abeni <[email protected]>
---
net/mac80211/rx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff -- a/net/mac80211/rx.c b/net/mac80211/rx.c
--- a/net/mac80211/rx.c
+++ b/net/mac80211/rx.c
@@ -920,7 +920,7 @@ static void ieee80211_parse_qos(struct i
* Drivers always need to pass packets that are aligned to two-byte boundaries
* to the stack.
*
- * Additionally, should, if possible, align the payload data in a way that
+ * Additionally, they should, if possible, align the payload data in a way that
* guarantees that the contained IP header is aligned to a four-byte
* boundary. In the case of regular frames, this simply means aligning the
* payload to a four-byte boundary (because either the IP header is directly
@@ -936,7 +936,7 @@ static void ieee80211_parse_qos(struct i
* subframe to a length that is a multiple of four.
*
* Padding like Atheros hardware adds which is between the 802.11 header and
- * the payload is not supported, the driver is required to move the 802.11
+ * the payload is not supported; the driver is required to move the 802.11
* header to be directly in front of the payload in that case.
*/
static void ieee80211_verify_alignment(struct ieee80211_rx_data *rx)

2023-12-14 17:41:43

by Simon Horman

Subject: Re: [PATCH] wifi: mac80211: rx.c: fix sentence grammar

On Tue, Dec 12, 2023 at 09:48:00PM -0800, Randy Dunlap wrote:
> Correct a run-on sentence by changing "," to ";".
> Add a subject in one sentence.
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Johannes Berg <[email protected]>
> Cc: Kalle Valo <[email protected]>
> Cc: [email protected]
> Cc: "David S. Miller" <[email protected]>
> Cc: Eric Dumazet <[email protected]>
> Cc: Jakub Kicinski <[email protected]>
> Cc: Paolo Abeni <[email protected]>
> ---
> net/mac80211/rx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Thanks Randy,

these changes look good to me.

Also, I checked and codespell doesn't report any errors in rx.c

Reviewed-by: Simon Horman <[email protected]>