2023-12-13 05:48:21

by Randy Dunlap

Subject: [PATCH] wifi: mac80211: sta_info.c: fix sentence grammar

Correct run-on sentences by changing "," to ";".

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Johannes Berg <[email protected]>
Cc: Kalle Valo <[email protected]>
Cc: [email protected]
Cc: "David S. Miller" <[email protected]>
Cc: Eric Dumazet <[email protected]>
Cc: Jakub Kicinski <[email protected]>
Cc: Paolo Abeni <[email protected]>
---
net/mac80211/sta_info.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff -- a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
--- a/net/mac80211/sta_info.c
+++ b/net/mac80211/sta_info.c
@@ -40,7 +40,7 @@
* either sta_info_insert() or sta_info_insert_rcu(); only in the latter
* case (which acquires an rcu read section but must not be called from
* within one) will the pointer still be valid after the call. Note that
- * the caller may not do much with the STA info before inserting it, in
+ * the caller may not do much with the STA info before inserting it; in
* particular, it may not start any mesh peer link management or add
* encryption keys.
*
@@ -58,7 +58,7 @@
* In order to remove a STA info structure, various sta_info_destroy_*()
* calls are available.
*
- * There is no concept of ownership on a STA entry, each structure is
+ * There is no concept of ownership on a STA entry; each structure is
* owned by the global hash table/list until it is removed. All users of
* the structure need to be RCU protected so that the structure won't be
* freed before they are done using it.

2023-12-14 17:43:33

by Simon Horman

Subject: Re: [PATCH] wifi: mac80211: sta_info.c: fix sentence grammar

On Tue, Dec 12, 2023 at 09:48:09PM -0800, Randy Dunlap wrote:
> Correct run-on sentences by changing "," to ";".
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Johannes Berg <[email protected]>
> Cc: Kalle Valo <[email protected]>
> Cc: [email protected]
> Cc: "David S. Miller" <[email protected]>
> Cc: Eric Dumazet <[email protected]>
> Cc: Jakub Kicinski <[email protected]>
> Cc: Paolo Abeni <[email protected]>
> ---
> net/mac80211/sta_info.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Thanks Randy,

these changes look good to me.

Also, I checked and codespell does not report any errors in sta_info.c

Reviewed-by: Simon Horman <[email protected]>

...