2023-12-18 15:06:29

by Dmitry Antipov

[permalink] [raw]
Subject: [PATCH] wifi: iwlwifi: dvm: do not set priv_sta of rs_get_rate()

Since commit 1e87fec9fa52 ("mac80211: call rate_control_send_low()
internally") removes an explicit call to 'rate_control_send_low()'
from 'rs_get_rate()' and 'priv_sta' is no longer used till the end
of the function, there is no need to reset it to NULL. Compile
tested only.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Dmitry Antipov <[email protected]>
---
drivers/net/wireless/intel/iwlwifi/dvm/rs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/rs.c b/drivers/net/wireless/intel/iwlwifi/dvm/rs.c
index f4a6f76cf193..ab237cb1d91d 100644
--- a/drivers/net/wireless/intel/iwlwifi/dvm/rs.c
+++ b/drivers/net/wireless/intel/iwlwifi/dvm/rs.c
@@ -2684,10 +2684,8 @@ static void rs_get_rate(void *priv_r, struct ieee80211_sta *sta, void *priv_sta,
}

/* Treat uninitialized rate scaling data same as non-existing. */
- if (lq_sta && !lq_sta->drv) {
+ if (lq_sta && !lq_sta->drv)
IWL_DEBUG_RATE(priv, "Rate scaling not initialized yet.\n");
- priv_sta = NULL;
- }

rate_idx = lq_sta->last_txrate_idx;

--
2.43.0