2024-01-01 05:13:53

by Zenm Chen

[permalink] [raw]
Subject: [PATCH v3] wifi: rtl8xxxu: Fix LED control code of RTL8192FU

Hi,

Thanks for making this patch.
I have no ASUS USB-N13 C1 now, so only tested with MERCUSYS MW310UH.
I think this patch will make the LEDs of ASUS USB-N13 C1/EDIMAX EW-7722UTn V3 work as expected.



2024-01-02 01:50:26

by Ping-Ke Shih

[permalink] [raw]
Subject: RE: [PATCH v3] wifi: rtl8xxxu: Fix LED control code of RTL8192FU



> -----Original Message-----
> From: Bitterblue Smith <[email protected]>
> Sent: Sunday, December 31, 2023 6:46 AM
> To: [email protected]
> Cc: Jes Sorensen <[email protected]>; Ping-Ke Shih <[email protected]>; Zenm Chen
> <[email protected]>
> Subject: [PATCH v3] wifi: rtl8xxxu: Fix LED control code of RTL8192FU
>
> Some devices, like the Comfast CF-826F, use LED1, which already works.
> Others, like Asus USB-N13 C1, use LED0, which doesn't work correctly.
>
> Write the right values to the LED control registers to make LED0 work
> as well.
>
> This is unfortunately tested only with the Comfast CF-826F.
>
> Signed-off-by: Bitterblue Smith <[email protected]>

Thank you and Zenm for this work!

Reviewed-by: Ping-Ke Shih <[email protected]>


2024-01-10 14:55:37

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH v3] wifi: rtl8xxxu: Fix LED control code of RTL8192FU

Bitterblue Smith <[email protected]> wrote:

> Some devices, like the Comfast CF-826F, use LED1, which already works.
> Others, like Asus USB-N13 C1, use LED0, which doesn't work correctly.
>
> Write the right values to the LED control registers to make LED0 work
> as well.
>
> This is unfortunately tested only with the Comfast CF-826F.
>
> Signed-off-by: Bitterblue Smith <[email protected]>
> Reviewed-by: Ping-Ke Shih <[email protected]>

Patch applied to wireless-next.git, thanks.

9475cc7ac315 wifi: rtl8xxxu: Fix LED control code of RTL8192FU

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches