2024-02-11 15:11:58

by Nicolas Escande

Subject: [PATCH] wifi: ath11k: remove unused scan_events from struct scan_req_params

As discussed in [1] lets remove the unused scan_events field from struct
scan_req_params. Also, as it is not needed anymore, remove the underlying union
wrapping too. No functionnal changes.

[1] https://lore.kernel.org/all/[email protected]/

Signed-off-by: Nicolas Escande <[email protected]>
---
drivers/net/wireless/ath/ath11k/wmi.h | 31 +++++++++++----------------
1 file changed, 13 insertions(+), 18 deletions(-)

diff --git a/drivers/net/wireless/ath/ath11k/wmi.h b/drivers/net/wireless/ath/ath11k/wmi.h
index bc7adf7f13fb..bb419e3abb00 100644
--- a/drivers/net/wireless/ath/ath11k/wmi.h
+++ b/drivers/net/wireless/ath/ath11k/wmi.h
@@ -3363,24 +3363,19 @@ struct scan_req_params {
u32 vdev_id;
u32 pdev_id;
enum wmi_scan_priority scan_priority;
- union {
- struct {
- u32 scan_ev_started:1,
- scan_ev_completed:1,
- scan_ev_bss_chan:1,
- scan_ev_foreign_chan:1,
- scan_ev_dequeued:1,
- scan_ev_preempted:1,
- scan_ev_start_failed:1,
- scan_ev_restarted:1,
- scan_ev_foreign_chn_exit:1,
- scan_ev_invalid:1,
- scan_ev_gpio_timeout:1,
- scan_ev_suspended:1,
- scan_ev_resumed:1;
- };
- u32 scan_events;
- };
+ u32 scan_ev_started:1,
+ scan_ev_completed:1,
+ scan_ev_bss_chan:1,
+ scan_ev_foreign_chan:1,
+ scan_ev_dequeued:1,
+ scan_ev_preempted:1,
+ scan_ev_start_failed:1,
+ scan_ev_restarted:1,
+ scan_ev_foreign_chn_exit:1,
+ scan_ev_invalid:1,
+ scan_ev_gpio_timeout:1,
+ scan_ev_suspended:1,
+ scan_ev_resumed:1;
u32 scan_ctrl_flags_ext;
u32 dwell_time_active;
u32 dwell_time_active_2g;
--
2.43.0

2024-02-15 11:31:43

by Kalle Valo

Subject: Re: [PATCH] wifi: ath11k: remove unused scan_events from struct scan_req_params

Nicolas Escande <[email protected]> wrote:

> As discussed lets remove the unused scan_events field from struct
> scan_req_params. Also, as it is not needed anymore, remove the underlying union
> wrapping too. No functionnal changes.
>
> Link: https://lore.kernel.org/all/[email protected]/
> Signed-off-by: Nicolas Escande <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

3ab6aff5793c wifi: ath11k: remove unused scan_events from struct scan_req_params

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches