2024-02-16 21:37:10

by Hans de Goede

[permalink] [raw]
Subject: [PATCH] wifi: brcmfmac: Add DMI nvram filename quirk for ACEPC W5 Pro

The ACEPC W5 Pro HDMI stick contains quite generic names in the sys_vendor
and product_name DMI strings, without this patch brcmfmac will try to load:
"brcmfmac43455-sdio.$(DEFAULT_STRING)-$(DEFAULT_STRING).txt" as nvram file
which is both too generic and messy with the $ symbols in the name.

The ACEPC W5 Pro uses the same Ampak AP6255 module as the ACEPC T8
and the nvram for the T8 is already in linux-firmware, so point the new
DMI nvram filename quirk to the T8 nvram file.

Signed-off-by: Hans de Goede <[email protected]>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c
index 86ff174936a9..c3a602197662 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c
@@ -82,6 +82,15 @@ static const struct dmi_system_id dmi_platform_data[] = {
},
.driver_data = (void *)&acepc_t8_data,
},
+ {
+ /* ACEPC W5 Pro Cherry Trail Z8350 HDMI stick, same wifi as the T8 */
+ .matches = {
+ DMI_MATCH(DMI_BOARD_NAME, "T3 MRD"),
+ DMI_MATCH(DMI_CHASSIS_TYPE, "3"),
+ DMI_MATCH(DMI_BIOS_VENDOR, "American Megatrends Inc."),
+ },
+ .driver_data = (void *)&acepc_t8_data,
+ },
{
/* Chuwi Hi8 Pro with D2D3_Hi8Pro.233 BIOS */
.matches = {
--
2.43.0



2024-02-17 21:53:12

by Arend Van Spriel

[permalink] [raw]
Subject: Re: [PATCH] wifi: brcmfmac: Add DMI nvram filename quirk for ACEPC W5 Pro

On February 16, 2024 10:37:06 PM Hans de Goede <[email protected]> wrote:

> The ACEPC W5 Pro HDMI stick contains quite generic names in the sys_vendor
> and product_name DMI strings, without this patch brcmfmac will try to load:
> "brcmfmac43455-sdio.$(DEFAULT_STRING)-$(DEFAULT_STRING).txt" as nvram file
> which is both too generic and messy with the $ symbols in the name.
>
> The ACEPC W5 Pro uses the same Ampak AP6255 module as the ACEPC T8
> and the nvram for the T8 is already in linux-firmware, so point the new
> DMI nvram filename quirk to the T8 nvram file.

Acked-by: Arend van Spriel <[email protected]>
> Signed-off-by: Hans de Goede <[email protected]>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c | 9 +++++++++
> 1 file changed, 9 insertions(+)



Attachments:
smime.p7s (4.12 kB)
S/MIME Cryptographic Signature

2024-02-21 18:56:39

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] wifi: brcmfmac: Add DMI nvram filename quirk for ACEPC W5 Pro

Hans de Goede <[email protected]> wrote:

> The ACEPC W5 Pro HDMI stick contains quite generic names in the sys_vendor
> and product_name DMI strings, without this patch brcmfmac will try to load:
> "brcmfmac43455-sdio.$(DEFAULT_STRING)-$(DEFAULT_STRING).txt" as nvram file
> which is both too generic and messy with the $ symbols in the name.
>
> The ACEPC W5 Pro uses the same Ampak AP6255 module as the ACEPC T8
> and the nvram for the T8 is already in linux-firmware, so point the new
> DMI nvram filename quirk to the T8 nvram file.
>
> Signed-off-by: Hans de Goede <[email protected]>
> Acked-by: Arend van Spriel <[email protected]>

Patch applied to wireless-next.git, thanks.

32167707aa5e wifi: brcmfmac: Add DMI nvram filename quirk for ACEPC W5 Pro

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches