2024-02-23 15:41:07

by Jeff Johnson

Subject: [PATCH] wifi: ath11k: constify MHI channel and controller configs

Unlike the event configuration which can be modified by MHI, the
channel and controller configurations are expected to be const. And
since they are not modified locally, constify them to prevent runtime
modification.

No functional changes, compile tested only.

Signed-off-by: Jeff Johnson <[email protected]>
---
drivers/net/wireless/ath/ath11k/mhi.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/wireless/ath/ath11k/mhi.c b/drivers/net/wireless/ath/ath11k/mhi.c
index b53659145fcf..7f566d9106fc 100644
--- a/drivers/net/wireless/ath/ath11k/mhi.c
+++ b/drivers/net/wireless/ath/ath11k/mhi.c
@@ -20,7 +20,7 @@
#define MHI_TIMEOUT_DEFAULT_MS 20000
#define RDDM_DUMP_SIZE 0x420000

-static struct mhi_channel_config ath11k_mhi_channels_qca6390[] = {
+static const struct mhi_channel_config ath11k_mhi_channels_qca6390[] = {
{
.num = 0,
.name = "LOOPBACK",
@@ -102,7 +102,7 @@ static struct mhi_event_config ath11k_mhi_events_qca6390[] = {
},
};

-static struct mhi_controller_config ath11k_mhi_config_qca6390 = {
+static const struct mhi_controller_config ath11k_mhi_config_qca6390 = {
.max_channels = 128,
.timeout_ms = 2000,
.use_bounce_buf = false,
@@ -113,7 +113,7 @@ static struct mhi_controller_config ath11k_mhi_config_qca6390 = {
.event_cfg = ath11k_mhi_events_qca6390,
};

-static struct mhi_channel_config ath11k_mhi_channels_qcn9074[] = {
+static const struct mhi_channel_config ath11k_mhi_channels_qcn9074[] = {
{
.num = 0,
.name = "LOOPBACK",
@@ -195,7 +195,7 @@ static struct mhi_event_config ath11k_mhi_events_qcn9074[] = {
},
};

-static struct mhi_controller_config ath11k_mhi_config_qcn9074 = {
+static const struct mhi_controller_config ath11k_mhi_config_qcn9074 = {
.max_channels = 30,
.timeout_ms = 10000,
.use_bounce_buf = false,
@@ -384,7 +384,7 @@ int ath11k_mhi_register(struct ath11k_pci *ab_pci)
{
struct ath11k_base *ab = ab_pci->ab;
struct mhi_controller *mhi_ctrl;
- struct mhi_controller_config *ath11k_mhi_config;
+ const struct mhi_controller_config *ath11k_mhi_config;
int ret;

mhi_ctrl = mhi_alloc_controller();

---
base-commit: 3ab6aff5793c3c7bdf6535d9b0024544a4abbdd5
change-id: 20240222-mhi-const-wifi-ath11k-da0aa098d683

2024-02-28 14:09:18

by Kalle Valo

Subject: Re: [PATCH] wifi: ath11k: constify MHI channel and controller configs

Jeff Johnson <[email protected]> wrote:

> Unlike the event configuration which can be modified by MHI, the
> channel and controller configurations are expected to be const. And
> since they are not modified locally, constify them to prevent runtime
> modification.
>
> No functional changes, compile tested only.
>
> Signed-off-by: Jeff Johnson <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

766cf07c4023 wifi: ath11k: constify MHI channel and controller configs

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches