2024-02-26 06:42:24

by Serge Vasilugin

Subject: [PATCH] wifi:rt2x00: don't overwrite SoC specific bbp init

SoCs rt305x have the same MAC version but SoC specific bbp init function

Signed-off-by: Serge Vailugin <[email protected]>
---

--- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
@@ -7257,7 +7257,8 @@ static void rt2800_init_bbp(struct rt2x00_dev *rt2x00dev)
case RT2860:
case RT2872:
case RT2883:
- rt2800_init_bbp_28xx(rt2x00dev);
+ if (!rt2800_is_305x_soc(rt2x00dev))
+ rt2800_init_bbp_28xx(rt2x00dev);
break;
case RT3070:
case RT3071:
--

2024-02-26 07:18:54

by Kalle Valo

Subject: Re: [PATCH] wifi:rt2x00: don't overwrite SoC specific bbp init

"serge" <[email protected]> writes:

> SoCs rt305x have the same MAC version but SoC specific bbp init function
>
> Signed-off-by: Serge Vailugin <[email protected]>

The commit message should answer to the question 'Why?'. What user
visible issue/symptom does this patch fix?

Also From field need to match with s-o-b, now the names are different.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches