2024-03-24 16:07:05

by Johan Hovold

Subject: [PATCH] wifi: mac80211: fix mlme_link_id_dbg()

Make sure that the new mlme_link_id_dbg() macro honours
CONFIG_MAC80211_MLME_DEBUG as intended to avoid spamming the log with
messages like:

wlan0: no EHT support, limiting to HE
wlan0: determined local STA to be HE, BW limited to 160 MHz
wlan0: determined AP xx:xx:xx:xx:xx:xx to be VHT
wlan0: connecting with VHT mode, max bandwidth 160 MHz

Fixes: 310c8387c638 ("wifi: mac80211: clean up connection process")
Signed-off-by: Johan Hovold <[email protected]>
---
net/mac80211/debug.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/mac80211/debug.h b/net/mac80211/debug.h
index 49da401c5340..35a8ba25fa57 100644
--- a/net/mac80211/debug.h
+++ b/net/mac80211/debug.h
@@ -158,7 +158,7 @@ do { \
_sdata_dbg(print, sdata, "[link %d] " fmt, \
link_id, ##__VA_ARGS__); \
else \
- _sdata_dbg(1, sdata, fmt, ##__VA_ARGS__); \
+ _sdata_dbg(print, sdata, fmt, ##__VA_ARGS__); \
} while (0)
#define link_dbg(link, fmt, ...) \
_link_id_dbg(1, (link)->sdata, (link)->link_id, \
--
2.43.2

2024-03-25 16:08:47

by Kalle Valo

Subject: Re: [PATCH] wifi: mac80211: fix mlme_link_id_dbg()

Johan Hovold <[email protected]> writes:

> Make sure that the new mlme_link_id_dbg() macro honours
> CONFIG_MAC80211_MLME_DEBUG as intended to avoid spamming the log with
> messages like:
>
> wlan0: no EHT support, limiting to HE
> wlan0: determined local STA to be HE, BW limited to 160 MHz
> wlan0: determined AP xx:xx:xx:xx:xx:xx to be VHT
> wlan0: connecting with VHT mode, max bandwidth 160 MHz
>
> Fixes: 310c8387c638 ("wifi: mac80211: clean up connection process")
> Signed-off-by: Johan Hovold <[email protected]>

Thanks, I also noticed the extra messages. It would be good to get this
to v6.9.

Tested-by: Kalle Valo <[email protected]>

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches