2024-04-11 03:03:13

by Lingbo Kong

[permalink] [raw]
Subject: [PATCH 0/3] wifi: ath12k: report station mode stats

Currently, the transmit rate, the receive rate and signal strength of
“iw dev xxx station dump” always show an invalid value.

This is because ath12k has no logic to handle this relevant information.

To solve this issue, ath12k parses the information passed by the firmware
and passes it to mac80211.

After that, "iw dev xxx station dump" show the correct value.
Such as:

Station 00:03:7f:12:03:03 (on wlo1)
inactive time: 600 ms
rx bytes: 4642228
rx packets: 23796
tx bytes: 933967
tx packets: 8761
tx retries: 66
tx failed: 0
beacon loss: 0
beacon rx: 8925
rx drop misc: 191
signal: -20 dBm
beacon signal avg: -18 dBm
tx bitrate: 1441.1 MBit/s 80MHz EHT-MCS 13 EHT-NSS 2 EHT-GI 0
tx duration: 0 us
rx bitrate: 1801.4 MBit/s 80MHz EHT-MCS 11 EHT-NSS 3 EHT-GI 0
rx duration: 0 us

Lingbo Kong (3):
wifi: ath12k: report station mode transmit rate
wifi: ath12k: report station mode receive rate for IEEE 802.11be
wifi: ath12k: report station mode signal strength

drivers/net/wireless/ath/ath12k/core.h | 4 +
drivers/net/wireless/ath/ath12k/dp_rx.c | 20 ++-
drivers/net/wireless/ath/ath12k/dp_rx.h | 3 +
drivers/net/wireless/ath/ath12k/dp_tx.c | 147 +++++++++++++++++-
drivers/net/wireless/ath/ath12k/hal_tx.h | 9 +-
drivers/net/wireless/ath/ath12k/mac.c | 180 +++++++++++++++++++++-
drivers/net/wireless/ath/ath12k/mac.h | 3 +
drivers/net/wireless/ath/ath12k/rx_desc.h | 2 +
drivers/net/wireless/ath/ath12k/wmi.c | 130 ++++++++++++++++
drivers/net/wireless/ath/ath12k/wmi.h | 48 ++++++
10 files changed, 537 insertions(+), 9 deletions(-)


base-commit: dc410c4accd2fe64479a1f4ebc47ec9cd3928f4a
--
2.34.1



2024-04-11 21:40:46

by Jeff Johnson

[permalink] [raw]
Subject: Re: [PATCH 0/3] wifi: ath12k: report station mode stats

On 4/10/2024 7:53 PM, Lingbo Kong wrote:
> Currently, the transmit rate, the receive rate and signal strength of
> “iw dev xxx station dump” always show an invalid value.
>
> This is because ath12k has no logic to handle this relevant information.
>
> To solve this issue, ath12k parses the information passed by the firmware
> and passes it to mac80211.
>
> After that, "iw dev xxx station dump" show the correct value.
> Such as:
>
> Station 00:03:7f:12:03:03 (on wlo1)
> inactive time: 600 ms
> rx bytes: 4642228
> rx packets: 23796
> tx bytes: 933967
> tx packets: 8761
> tx retries: 66
> tx failed: 0
> beacon loss: 0
> beacon rx: 8925
> rx drop misc: 191
> signal: -20 dBm
> beacon signal avg: -18 dBm
> tx bitrate: 1441.1 MBit/s 80MHz EHT-MCS 13 EHT-NSS 2 EHT-GI 0
> tx duration: 0 us
> rx bitrate: 1801.4 MBit/s 80MHz EHT-MCS 11 EHT-NSS 3 EHT-GI 0
> rx duration: 0 us
>
> Lingbo Kong (3):
> wifi: ath12k: report station mode transmit rate
> wifi: ath12k: report station mode receive rate for IEEE 802.11be
> wifi: ath12k: report station mode signal strength
>
> drivers/net/wireless/ath/ath12k/core.h | 4 +
> drivers/net/wireless/ath/ath12k/dp_rx.c | 20 ++-
> drivers/net/wireless/ath/ath12k/dp_rx.h | 3 +
> drivers/net/wireless/ath/ath12k/dp_tx.c | 147 +++++++++++++++++-
> drivers/net/wireless/ath/ath12k/hal_tx.h | 9 +-
> drivers/net/wireless/ath/ath12k/mac.c | 180 +++++++++++++++++++++-
> drivers/net/wireless/ath/ath12k/mac.h | 3 +
> drivers/net/wireless/ath/ath12k/rx_desc.h | 2 +
> drivers/net/wireless/ath/ath12k/wmi.c | 130 ++++++++++++++++
> drivers/net/wireless/ath/ath12k/wmi.h | 48 ++++++
> 10 files changed, 537 insertions(+), 9 deletions(-)
>
>
> base-commit: dc410c4accd2fe64479a1f4ebc47ec9cd3928f4a

FYI I'm not able to verify this series since it conflicts with the pending branch.

Patch failed at 0003 wifi: ath12k: report station mode signal strength
error: patch failed: drivers/net/wireless/ath/ath12k/core.h:607
error: drivers/net/wireless/ath/ath12k/core.h: patch does not apply
error: patch failed: drivers/net/wireless/ath/ath12k/mac.c:7561
error: drivers/net/wireless/ath/ath12k/mac.c: patch does not apply

Note that wireless-testing doesn't have the following series which conflicts:
wifi: ath12k: Add single wiphy support

Can you rebase against either ath-next or pending, both of which have that series?