2024-05-29 06:10:14

by Harshitha Prem

Subject: [PATCH] wifi: ath12k: Remove unused ath12k_base from ath12k_hw

Currently, device (ab) reference in hardware abstraction (ah)
is not used anywhere. Also, with multiple device group abstraction,
hardware abstraction would be coupled with device group abstraction
rather than single device.

Hence, remove the ab reference from hardware abstraction.

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1

Signed-off-by: Harshitha Prem <[email protected]>
---
Depends-On: [PATCH] wifi: ath12k: Fix WARN_ON during firmware crash in split-phy
Link: https://lore.kernel.org/ath12k/[email protected]/
---
drivers/net/wireless/ath/ath12k/core.h | 2 --
drivers/net/wireless/ath/ath12k/mac.c | 1 -
2 files changed, 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath12k/core.h b/drivers/net/wireless/ath/ath12k/core.h
index 96fafa0e05dc..1d8837bdacf6 100644
--- a/drivers/net/wireless/ath/ath12k/core.h
+++ b/drivers/net/wireless/ath/ath12k/core.h
@@ -628,8 +628,6 @@ struct ath12k {

struct ath12k_hw {
struct ieee80211_hw *hw;
- struct ath12k_base *ab;
-
/* Protect the write operation of the hardware state ath12k_hw::state
* between hardware start<=>reconfigure<=>stop transitions.
*/
diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
index 33616ab795af..b3127df5a702 100644
--- a/drivers/net/wireless/ath/ath12k/mac.c
+++ b/drivers/net/wireless/ath/ath12k/mac.c
@@ -9193,7 +9193,6 @@ static struct ath12k_hw *ath12k_mac_hw_allocate(struct ath12k_base *ab,

ah = ath12k_hw_to_ah(hw);
ah->hw = hw;
- ah->ab = ab;
ah->num_radio = num_pdev_map;

mutex_init(&ah->hw_mutex);

base-commit: 2580be9ee6f5d97d6763b5d4ae4f9c0383fdf130
prerequisite-patch-id: 7e8274d96448b7b4bd2d22057a31d95431be6662
--
2.34.1

2024-05-29 16:52:04

by Jeff Johnson

Subject: Re: [PATCH] wifi: ath12k: Remove unused ath12k_base from ath12k_hw

On 5/28/2024 11:09 PM, Harshitha Prem wrote:
> Currently, device (ab) reference in hardware abstraction (ah)
> is not used anywhere. Also, with multiple device group abstraction,
> hardware abstraction would be coupled with device group abstraction
> rather than single device.
>
> Hence, remove the ab reference from hardware abstraction.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Harshitha Prem <[email protected]>
> ---
> Depends-On: [PATCH] wifi: ath12k: Fix WARN_ON during firmware crash in split-phy
> Link: https://lore.kernel.org/ath12k/[email protected]/
> ---
Acked-by: Jeff Johnson <[email protected]>