2024-05-31 20:26:12

by Ramya Gnanasekar

[permalink] [raw]
Subject: [PATCH v3 0/5] wifi: ath12k: Add support to enable debugfs_htt_stats

Bring in the basic infrastructure necessary for enabling htt_stats via debugfs.
Patch series bring support to request stats type to firmware, dump the stats
and request to reset the stats from firmware.

Schema with one ath12k device:

ath12k
`-- pci-0000:06:00.0
|-- mac0
`-- htt_stats
|-- htt_stats_type
|-- htt_stats_reset

Dinesh Karthikeyan (3):
wifi: ath12k: Add support to enable debugfs_htt_stats
wifi: ath12k: Add htt_stats_dump file ops support
wifi: ath12k: Add support to parse requested stats_type

Lingbo Kong (1):
wifi: ath12k: Fix Pdev id in HTT stats request for WCN7850

Ramya Gnanasekar (1):
wifi: ath12k: Dump additional Tx PDEV HTT stats

drivers/net/wireless/ath/ath12k/Makefile | 2 +-
drivers/net/wireless/ath/ath12k/core.h | 11 +
drivers/net/wireless/ath/ath12k/debugfs.c | 3 +
.../wireless/ath/ath12k/debugfs_htt_stats.c | 714 ++++++++++++++++++
.../wireless/ath/ath12k/debugfs_htt_stats.h | 300 ++++++++
drivers/net/wireless/ath/ath12k/dp_rx.c | 10 +-
drivers/net/wireless/ath/ath12k/dp_rx.h | 4 +
drivers/net/wireless/ath/ath12k/dp_tx.c | 8 +-
drivers/net/wireless/ath/ath12k/mac.c | 61 ++
drivers/net/wireless/ath/ath12k/mac.h | 3 +
10 files changed, 1110 insertions(+), 6 deletions(-)
create mode 100644 drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
create mode 100644 drivers/net/wireless/ath/ath12k/debugfs_htt_stats.h


base-commit: 2580be9ee6f5d97d6763b5d4ae4f9c0383fdf130
--
2.34.1

---
v3:
- Addressed Kalle's comments
- Locking is taken care. ar::data_lock is used to protect stats
request completion and other HTT debug entities protected using
ar::conf_mutex.
- Fixed KASAN warning from WCN7580 during stats type write.
- Changed header style for MU PPDU stats printing routine
- Renamed function ath12k_debugfs_htt_stats_init() to
ath12k_debugfs_htt_stats_register()

- Added expected length check while parsing each tag to prevent
buffer overread.

v2:
- Handled pdev id sent in HTT stats request command for WCN7850
Added changes as a separate patch #3
- Tested in WCN7850 and added Tested-on tag
- Rebased on ToT
---


2024-06-03 04:09:55

by Ramya Gnanasekar

[permalink] [raw]
Subject: Re: [PATCH v3 0/5] wifi: ath12k: Add support to enable debugfs_htt_stats


On 6/1/2024 1:55 AM, Ramya Gnanasekar wrote:
> Bring in the basic infrastructure necessary for enabling htt_stats via debugfs.
> Patch series bring support to request stats type to firmware, dump the stats
> and request to reset the stats from firmware.
>
> Schema with one ath12k device:
>
> ath12k
> `-- pci-0000:06:00.0
> |-- mac0
> `-- htt_stats
> |-- htt_stats_type
> |-- htt_stats_reset
>
> Dinesh Karthikeyan (3):
> wifi: ath12k: Add support to enable debugfs_htt_stats
> wifi: ath12k: Add htt_stats_dump file ops support
> wifi: ath12k: Add support to parse requested stats_type
>
> Lingbo Kong (1):
> wifi: ath12k: Fix Pdev id in HTT stats request for WCN7850
>
> Ramya Gnanasekar (1):
> wifi: ath12k: Dump additional Tx PDEV HTT stats
>
> drivers/net/wireless/ath/ath12k/Makefile | 2 +-
> drivers/net/wireless/ath/ath12k/core.h | 11 +
> drivers/net/wireless/ath/ath12k/debugfs.c | 3 +
> .../wireless/ath/ath12k/debugfs_htt_stats.c | 714 ++++++++++++++++++
> .../wireless/ath/ath12k/debugfs_htt_stats.h | 300 ++++++++
> drivers/net/wireless/ath/ath12k/dp_rx.c | 10 +-
> drivers/net/wireless/ath/ath12k/dp_rx.h | 4 +
> drivers/net/wireless/ath/ath12k/dp_tx.c | 8 +-
> drivers/net/wireless/ath/ath12k/mac.c | 61 ++
> drivers/net/wireless/ath/ath12k/mac.h | 3 +
> 10 files changed, 1110 insertions(+), 6 deletions(-)
> create mode 100644 drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
> create mode 100644 drivers/net/wireless/ath/ath12k/debugfs_htt_stats.h
>
>
> base-commit: 2580be9ee6f5d97d6763b5d4ae4f9c0383fdf130

Please ignore the cover letter. Patches got missed due to mail issues.
Will be sending incremental version for the series.