2012-02-14 08:39:13

by Sujith Manoharan

Subject: [PATCH 3/4] ath9k: Modify CCK spur mitigation for AR9462

This improves sensitivity for CCK at specific channels.

Signed-off-by: Sujith Manoharan <[email protected]>
---
drivers/net/wireless/ath/ath9k/ar9003_phy.c | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/ar9003_phy.c b/drivers/net/wireless/ath/ath9k/ar9003_phy.c
index 70e27d2..941b915 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_phy.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_phy.c
@@ -171,6 +171,7 @@ static void ar9003_hw_spur_mitigate_mrc_cck(struct ath_hw *ah,
struct ath9k_channel *chan)
{
static const u32 spur_freq[4] = { 2420, 2440, 2464, 2480 };
+ static const u32 spur_freq_AR9462[2] = { 2440, 2464 };
int cur_bb_spur, negative = 0, cck_spur_freq;
int i;
int range, max_spur_cnts, synth_freq;
@@ -198,8 +199,12 @@ static void ar9003_hw_spur_mitigate_mrc_cck(struct ath_hw *ah,
range = 10;
synth_freq = chan->channel;
}
+ } else if (AR_SREV_9462(ah)) {
+ range = 5;
+ max_spur_cnts = 2;
+ synth_freq = chan->channel;
} else {
- range = AR_SREV_9462(ah) ? 5 : 10;
+ range = 10;
max_spur_cnts = 4;
synth_freq = chan->channel;
}
@@ -211,6 +216,8 @@ static void ar9003_hw_spur_mitigate_mrc_cck(struct ath_hw *ah,
if (AR_SREV_9485(ah) || AR_SREV_9340(ah) || AR_SREV_9330(ah))
cur_bb_spur = FBIN2FREQ(spur_fbin_ptr[i],
IS_CHAN_2GHZ(chan)) - synth_freq;
+ else if (AR_SREV_9462(ah))
+ cur_bb_spur = spur_freq_AR9462[i] - synth_freq;
else
cur_bb_spur = spur_freq[i] - synth_freq;

--
1.7.9

2012-02-14 09:07:01

by Mohammed Shafi

Subject: Re: [PATCH 3/4] ath9k: Modify CCK spur mitigation for AR9462

Hi Sujith,

On Tue, Feb 14, 2012 at 2:09 PM, Sujith Manoharan
<[email protected]> wrote:
> This improves sensitivity for CCK at specific channels.
>
> Signed-off-by: Sujith Manoharan <[email protected]>
> ---
> ?drivers/net/wireless/ath/ath9k/ar9003_phy.c | ? ?9 ++++++++-
> ?1 files changed, 8 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/ar9003_phy.c b/drivers/net/wireless/ath/ath9k/ar9003_phy.c
> index 70e27d2..941b915 100644
> --- a/drivers/net/wireless/ath/ath9k/ar9003_phy.c
> +++ b/drivers/net/wireless/ath/ath9k/ar9003_phy.c
> @@ -171,6 +171,7 @@ static void ar9003_hw_spur_mitigate_mrc_cck(struct ath_hw *ah,
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?struct ath9k_channel *chan)
> ?{
> ? ? ? ?static const u32 spur_freq[4] = { 2420, 2440, 2464, 2480 };
> + ? ? ? static const u32 spur_freq_AR9462[2] = { 2440, 2464 };
> ? ? ? ?int cur_bb_spur, negative = 0, cck_spur_freq;
> ? ? ? ?int i;
> ? ? ? ?int range, max_spur_cnts, synth_freq;
> @@ -198,8 +199,12 @@ static void ar9003_hw_spur_mitigate_mrc_cck(struct ath_hw *ah,
> ? ? ? ? ? ? ? ? ? ? ? ?range = 10;
> ? ? ? ? ? ? ? ? ? ? ? ?synth_freq = chan->channel;
> ? ? ? ? ? ? ? ?}
> + ? ? ? } else if (AR_SREV_9462(ah)) {
> + ? ? ? ? ? ? ? range = 5;
> + ? ? ? ? ? ? ? max_spur_cnts = 2;
> + ? ? ? ? ? ? ? synth_freq = chan->channel;
> ? ? ? ?} else {
> - ? ? ? ? ? ? ? range = AR_SREV_9462(ah) ? 5 : 10;
> + ? ? ? ? ? ? ? range = 10;
> ? ? ? ? ? ? ? ?max_spur_cnts = 4;
> ? ? ? ? ? ? ? ?synth_freq = chan->channel;
> ? ? ? ?}
> @@ -211,6 +216,8 @@ static void ar9003_hw_spur_mitigate_mrc_cck(struct ath_hw *ah,
> ? ? ? ? ? ? ? ?if (AR_SREV_9485(ah) || AR_SREV_9340(ah) || AR_SREV_9330(ah))
> ? ? ? ? ? ? ? ? ? ? ? ?cur_bb_spur = FBIN2FREQ(spur_fbin_ptr[i],
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?IS_CHAN_2GHZ(chan)) - synth_freq;
> + ? ? ? ? ? ? ? else if (AR_SREV_9462(ah))
> + ? ? ? ? ? ? ? ? ? ? ? cur_bb_spur = spur_freq_AR9462[i] - synth_freq;
> ? ? ? ? ? ? ? ?else
> ? ? ? ? ? ? ? ? ? ? ? ?cur_bb_spur = spur_freq[i] - synth_freq;

i saw this some time back ,the check will not take care of this logic

if (AR_SREV_9462(ah) && (i == 0 || i == 3))
continue;

please let me know if i had missed something

>
> --
> 1.7.9
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html



--
shafi

2012-02-14 09:23:32

by Sujith Manoharan

Subject: Re: [PATCH 3/4] ath9k: Modify CCK spur mitigation for AR9462

Mohammed Shafi wrote:
> i saw this some time back ,the check will not take care of this logic
>
> if (AR_SREV_9462(ah) && (i == 0 || i == 3))
> continue;

Yep, looks like this is already handled. Thanks for catching this.

Sujith