2012-04-12 04:23:15

by Linus Torvalds

[permalink] [raw]
Subject: Regression due to "ath9k: fix going to full-sleep on PS idle"

On Wed, Apr 11, 2012 at 9:16 PM, Heinz Diehl <[email protected]> wrote:
> On 12.04.2012, Sergio Correia wrote:
>
>> is there any chance for this one to be included in this review cycle?
>>
>> http://www.spinics.net/lists/linux-wireless/msg87999.html
>
> Thanks for pointing this out! This patch fixes my network problems
> which forced me to go back to a previous kernel.

You guys need to fix the subject line (like this), and make sure that
the right people are cc'd. This is not a "stable" issue - stable
cannot revert stuff that hasn't been reverted upstream.

So instead of stable and Greg, it should be netdev and Davem.

David/John: multiple people are complaining about that commit. It
really should be reverted, or a fix found. It's broken.

I can do the revert, but it would be better coming from the networking people.

Linus


2012-04-12 13:32:35

by John W. Linville

[permalink] [raw]
Subject: Re: Regression due to "ath9k: fix going to full-sleep on PS idle"

On Thu, Apr 12, 2012 at 10:37:44AM +0530, Sujith Manoharan wrote:
> Linus Torvalds wrote:
> > You guys need to fix the subject line (like this), and make sure that
> > the right people are cc'd. This is not a "stable" issue - stable
> > cannot revert stuff that hasn't been reverted upstream.
> >
> > So instead of stable and Greg, it should be netdev and Davem.
> >
> > David/John: multiple people are complaining about that commit. It
> > really should be reverted, or a fix found. It's broken.
> >
> > I can do the revert, but it would be better coming from the networking people.
>
> John has already reverted the commit:
> http://git.kernel.org/?p=linux/kernel/git/linville/wireless.git;a=commit;h=011afa1ed8c408d694957d2474d89dc81a60b70c

Yes, I'll be pushing to Dave M shortly.

John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.

2012-04-12 05:08:39

by Sujith Manoharan

[permalink] [raw]
Subject: Regression due to "ath9k: fix going to full-sleep on PS idle"

Linus Torvalds wrote:
> You guys need to fix the subject line (like this), and make sure that
> the right people are cc'd. This is not a "stable" issue - stable
> cannot revert stuff that hasn't been reverted upstream.
>
> So instead of stable and Greg, it should be netdev and Davem.
>
> David/John: multiple people are complaining about that commit. It
> really should be reverted, or a fix found. It's broken.
>
> I can do the revert, but it would be better coming from the networking people.

John has already reverted the commit:
http://git.kernel.org/?p=linux/kernel/git/linville/wireless.git;a=commit;h=011afa1ed8c408d694957d2474d89dc81a60b70c

Sujith