2012-05-24 04:05:01

by Sujith Manoharan

Subject: [PATCH v2 20/22] ath9k: always perform ani calibration at poll

From: Rajkumar Manoharan <[email protected]>

Skiping the ani based on power state is delaying the ani cycles
further on an idle state. And also as the power state is updated
in different contexts, let us not skip the ani calibration.

Signed-off-by: Rajkumar Manoharan <[email protected]>
---
drivers/net/wireless/ath/ath9k/main.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index 3e8bef8..b9c9f4c 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -554,10 +554,6 @@ void ath_ani_calibrate(unsigned long data)
short_cal_interval = (ah->opmode == NL80211_IFTYPE_AP) ?
ATH_AP_SHORT_CALINTERVAL : ATH_STA_SHORT_CALINTERVAL;

- /* Only calibrate if awake */
- if (sc->sc_ah->power_mode != ATH9K_PM_AWAKE)
- goto set_timer;
-
ath9k_ps_wakeup(sc);

/* Long calibration runs independently of short calibration. */
@@ -613,7 +609,6 @@ void ath_ani_calibrate(unsigned long data)

ath9k_ps_restore(sc);

-set_timer:
/*
* Set timer interval based on previous results.
* The interval must be the shortest necessary to satisfy ANI,
--
1.7.10.2

2012-06-01 06:14:14

by Rajkumar Manoharan

Subject: Re: [PATCH v2 20/22] ath9k: always perform ani calibration at poll

On Thu, May 24, 2012 at 09:33:55AM +0530, Sujith Manoharan wrote:
>
> From: Rajkumar Manoharan <[email protected]>
>
> Skiping the ani based on power state is delaying the ani cycles
> further on an idle state. And also as the power state is updated
> in different contexts, let us not skip the ani calibration.
>
> Signed-off-by: Rajkumar Manoharan <[email protected]>
> ---
> drivers/net/wireless/ath/ath9k/main.c | 5 -----
> 1 file changed, 5 deletions(-)
John,

Can you please drop this patch alone from the patch series as it does
not make any improvement. Sorry for the inconvenience.

--
Rajkumar