2010-11-16 09:12:44

by Wojciech Dubowik

[permalink] [raw]
Subject: Re: [PATCH v4 0/9] ath5k: Add AHB support

> This series of patches implements AHB bus support for ath5k driver.
>
> General comments for AHB bus support in ath5k:
> * original patches came from Felix Fetikau
> * tried with access point functionality with WPA2 and without
> encryption
> * tested on AR5312 and AR2313for AHB and AR5414 and AR5212 for PCI
> * compat wireless 2010-11-10 from openwrt was used for testing
> * last two patches have to be applied together because otherwise
> hardware will crash on reset if only number 9 is committed.
> I have kept them separated for better visibility.
> There are three false positive checkpatch warnings from them.
>
> Wojciech Dubowik (9):
> ath5k: Use Generic DMA for later support of AHB bus. From:
> Felix
> Fietkau <[email protected]>
> ath5k: Introduce ath5k_init_softc function as in ath9k From:
> Felix Fietkau <[email protected]>
> ath5k: Move PCI bus functions to separate file. From: Felix
> Fietkau <[email protected]>
> ath5k: Use generic eeprom read from common ath_bus_opts struct.
> From: Felix Fietkau <[email protected]>
> ath5k: Check if pci pdev struct is initialized in common functions.
>
> From: Felix Fietkau <[email protected]>
> ath5k: Add a function to read chipset's MAC revision From:
> Felix
> Fietkau <[email protected]>
> ath5k: Add initial registers values for radio RF2317 chip.
> From:
> Felix Fietkau <[email protected]>
> ath5k: Add AHB bus support. From: Felix Fietkau
> <[email protected]>
> ath5k: Fix reset and interrupts for AHB type of devices. From:
> Felix Fietkau <[email protected]>
>
> drivers/net/wireless/ath/ath5k/Kconfig | 17 +-
> drivers/net/wireless/ath/ath5k/Makefile | 2 +
> drivers/net/wireless/ath/ath5k/ahb.c | 219 ++++++++++
> drivers/net/wireless/ath/ath5k/ath5k.h | 37 ++-
> drivers/net/wireless/ath/ath5k/attach.c | 26 +-
> drivers/net/wireless/ath/ath5k/base.c | 626
> ++++++++++-------------------
> drivers/net/wireless/ath/ath5k/base.h | 5 +-
> drivers/net/wireless/ath/ath5k/eeprom.c | 40 +--
> drivers/net/wireless/ath/ath5k/eeprom.h | 2 +-
> drivers/net/wireless/ath/ath5k/initvals.c | 23 +
> drivers/net/wireless/ath/ath5k/led.c | 11 +-
> drivers/net/wireless/ath/ath5k/pci.c | 326 +++++++++++++++
> drivers/net/wireless/ath/ath5k/reg.h | 25 ++
> drivers/net/wireless/ath/ath5k/reset.c | 116 ++++--
> drivers/net/wireless/ath/ath5k/sysfs.c | 4 +-
> 15 files changed, 988 insertions(+), 491 deletions(-)
> create mode 100644 drivers/net/wireless/ath/ath5k/ahb.c
> create mode 100644 drivers/net/wireless/ath/ath5k/pci.c

Obviously my script to send patches didn't work as expected so I will have to send them again.

Wojtek