2010-03-20 01:28:46

by Sedat Dilek

[permalink] [raw]
Subject: [ath9k_htc] Wrong kernel config parameters in wiki?

Hi,

a person asked on IRC about ath9k_htc support.

First question:
Has the patch from [1] already entered one of the wireless-* GIT repositories?

I could apply the ath9k_htc patch against 2.6.34-rc1-git9.

The kernel config parameters in wiki [2] seems to be wrong to me:

CONFIG_ATH=m
CONFIG_ATH9K_HW=m
CONFIG_ATH9K_HTC=m

Checking here:

$ grep CONFIG_ATH .config
CONFIG_ATH_COMMON=m
# CONFIG_ATH_DEBUG is not set
CONFIG_ATH5K=m
# CONFIG_ATH5K_DEBUG is not set
CONFIG_ATH9K_HW=m
CONFIG_ATH9K_COMMON=m
CONFIG_ATH9K=m
# CONFIG_ATH9K_DEBUGFS is not set
CONFIG_ATH9K_HTC=m
# CONFIG_ATH9K_HTC_DEBUGFS is not set

Should CONFIG_ATH=m be replaced by one/both of these ones?

$ grep CONFIG_ATH .config | grep COMMON
CONFIG_ATH_COMMON=m
CONFIG_ATH9K_COMMON=m

File drivers/net/wireless/ath/ath9k/Kconfig says:
...
config ATH9K_HTC
tristate "Atheros HTC based wireless cards support"
depends on USB && MAC80211
select ATH9K_HW
select MAC80211_LEDS
select LEDS_CLASS
select NEW_LEDS
---help---
Support for Atheros HTC based cards.
Chipsets supported: AR9271

For more information: http://wireless.kernel.org/en/users/Drivers/ath9k_htc

The built module will be ath9k_htc.
...

Maybe the confusion results from drivers/net/wireless/ath/Kconfig:

menuconfig ATH_COMMON
tristate "Atheros Wireless Cards"
...

IMHO setting CONFIG_ATH9K_HW=m and CONFIG_ATH9K_HTC=m should be enough.

Who can clarify?

Thanks in advance.

Kind Regards,
- Sedat -

References:
------------------
[1] https://patchwork.kernel.org/patch/82299/
[2] http://wireless.kernel.org/en/users/Drivers/ath9k_htc#Configuring_your_kernel
[3] http://wireless.kernel.org/en/users/Drivers/ath9k_htc


2010-03-22 05:01:20

by Sujith

[permalink] [raw]
Subject: [ath9k_htc] Wrong kernel config parameters in wiki?

Sedat Dilek wrote:
> Hi,
>
> a person asked on IRC about ath9k_htc support.
>
> First question:
> Has the patch from [1] already entered one of the wireless-* GIT repositories?

Nope, the driver has not been merged yet.
A revised series (12 patches) was submitted.
They should be available on patchwork.

> I could apply the ath9k_htc patch against 2.6.34-rc1-git9.
>
> The kernel config parameters in wiki [2] seems to be wrong to me:
>
> CONFIG_ATH=m
> CONFIG_ATH9K_HW=m
> CONFIG_ATH9K_HTC=m

Yep, they are wrong and are fixed now.

Sujith

2010-03-22 08:05:17

by Sedat Dilek

[permalink] [raw]
Subject: Re: [ath9k_htc] Wrong kernel config parameters in wiki?

On Mon, Mar 22, 2010 at 6:21 AM, Sujith <[email protected]> wrote:
> Sedat Dilek wrote:
>> Hi,
>>
>> a person asked on IRC about ath9k_htc support.
>>
>> First question:
>> Has the patch from [1] already entered one of the wireless-* GIT repositories?
>
> Nope, the driver has not been merged yet.
> A revised series (12 patches) was submitted.
> They should be available on patchwork.
>

New patchset from [1] applies cleanly against 2.6.34-rc2.

>> I could apply the ath9k_htc patch against 2.6.34-rc1-git9.
>>
>> The kernel config parameters in wiki [2] seems to be wrong to me:
>>
>> CONFIG_ATH=m
>> CONFIG_ATH9K_HW=m
>> CONFIG_ATH9K_HTC=m
>
> Yep, they are wrong and are fixed now.
>

The correct kernel config parameters are (only for documentation purposes):

CONFIG_ATH_COMMON=m
CONFIG_ATH9K_HW=m
CONFIG_ATH9K_COMMON=m
CONFIG_ATH9K_HTC=m

Thanks for the informations.

--
Sedat

[1] https://patchwork.kernel.org/patch/{86517..86528}/ (12 patches)