2019-08-22 08:47:53

by Felix Fietkau

[permalink] [raw]
Subject: Re: [PATCH 1/1] [PATCH] Mt76 enabling data pkt transmission.

On 2019-08-20 23:11, Balakrishna Bandi wrote:
> Data Packet transmission was disabled during scanning in mt76 driver.
>
> Fix to be, enabling data packet transmission during scanning.
>
> Note:
> Mac80211 will handle channel switching. During scanning, it handles
> stopping the data transmission on off channel and enabling data
> transmission on operating channel also. It does not require to stop data
> transmission in mt76 driver during scanning. Verified with other driver
> ath9k and rt2x00 driver, data transmission was not stopped during
> scanning
>
> Signed-off-by: Balakrishna Bandi <[email protected]>
> ---
> drivers/net/wireless/mediatek/mt76/tx.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/tx.c b/drivers/net/wireless/mediatek/mt76/tx.c
> index 5397827..376720d 100644
> --- a/drivers/net/wireless/mediatek/mt76/tx.c
> +++ b/drivers/net/wireless/mediatek/mt76/tx.c
> @@ -438,8 +438,7 @@ void mt76_tx_complete_skb(struct mt76_dev *dev, struct sk_buff *skb)
> if (probe)
> break;
>
> - if (test_bit(MT76_OFFCHANNEL, &dev->state) ||
> - test_bit(MT76_RESET, &dev->state))
> + if (test_bit(MT76_RESET, &dev->state))
The patch is incomplete, since this test is done twice in the tx path.
Also, the subject line is wrong. I will send a more complete fix.

Thanks,

- Felix