2014-07-20 14:26:33

by Fabian Frédérick

Subject: [PATCH 10/30] rtlwifi: rtl8188ee: remove unnecessary break after return

Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/net/wireless/rtlwifi/rtl8188ee/pwrseqcmd.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/rtlwifi/rtl8188ee/pwrseqcmd.c b/drivers/net/wireless/rtlwifi/rtl8188ee/pwrseqcmd.c
index a9cfa13..0f93142 100644
--- a/drivers/net/wireless/rtlwifi/rtl8188ee/pwrseqcmd.c
+++ b/drivers/net/wireless/rtlwifi/rtl8188ee/pwrseqcmd.c
@@ -125,7 +125,6 @@ bool rtl88_hal_pwrseqcmdparsing(struct rtl_priv *rtlpriv, u8 cut_version,
RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
"rtl88_hal_pwrseqcmdparsing(): PWR_CMD_END\n");
return true;
- break;
default:
RT_ASSERT(false,
"rtl88_hal_pwrseqcmdparsing(): Unknown CMD!!\n");
--
1.9.1

2014-07-21 08:17:25

by Kalle Valo

Subject: Re: [PATCH 14/30] ath6kl: remove unnecessary break after return

Fabian Frederick <[email protected]> writes:

> Signed-off-by: Fabian Frederick <[email protected]>

Acked-by: Kalle Valo <[email protected]>

Who is taking this patch? Please let me know if I should apply it to my
tree.

--
Kalle Valo

2014-07-20 14:26:42

by Fabian Frédérick

Subject: [PATCH 13/30] airo: remove unnecessary break after return

Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/net/wireless/airo.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c
index 64747d4..c26359d 100644
--- a/drivers/net/wireless/airo.c
+++ b/drivers/net/wireless/airo.c
@@ -7817,7 +7817,6 @@ static int readrids(struct net_device *dev, aironet_ioctl *comp) {
case AIRORRID: ridcode = comp->ridnum; break;
default:
return -EINVAL;
- break;
}

if ((iobuf = kmalloc(RIDSIZE, GFP_KERNEL)) == NULL)
--
1.9.1

2014-07-20 14:26:43

by Fabian Frédérick

Subject: [PATCH 14/30] ath6kl: remove unnecessary break after return

Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/net/wireless/ath/ath6kl/init.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c
index d5ef211..8ee7097 100644
--- a/drivers/net/wireless/ath/ath6kl/init.c
+++ b/drivers/net/wireless/ath/ath6kl/init.c
@@ -1187,7 +1187,6 @@ static int ath6kl_upload_board_file(struct ath6kl *ar)
default:
WARN_ON(1);
return -EINVAL;
- break;
}

if (board_ext_address &&
--
1.9.1

2014-07-20 14:26:37

by Fabian Frédérick

Subject: [PATCH 11/30] prism54: remove unnecessary break after return

Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/net/wireless/prism54/oid_mgt.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/prism54/oid_mgt.c b/drivers/net/wireless/prism54/oid_mgt.c
index 47b34bf..3a8d2db 100644
--- a/drivers/net/wireless/prism54/oid_mgt.c
+++ b/drivers/net/wireless/prism54/oid_mgt.c
@@ -793,7 +793,6 @@ mgt_response_to_str(enum oid_num_t n, union oid_res_t *r, char *str)
switch (isl_oid[n].flags & OID_FLAG_TYPE) {
case OID_TYPE_U32:
return snprintf(str, PRIV_STR_SIZE, "%u\n", r->u);
- break;
case OID_TYPE_BUFFER:{
struct obj_buffer *buff = r->ptr;
return snprintf(str, PRIV_STR_SIZE,
--
1.9.1

2014-07-21 08:15:24

by Christian Lamparter

Subject: Re: [PATCH 15/30] carl9170: remove unnecessary break after return

On Sunday, July 20, 2014 04:25:16 PM Fabian Frederick wrote:
> Signed-off-by: Fabian Frederick <[email protected]>

Acked-by: Christian Lamparter <[email protected]>
> ---
> drivers/net/wireless/ath/carl9170/phy.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/carl9170/phy.c b/drivers/net/wireless/ath/carl9170/phy.c
> index ab4ee7d..b80b213 100644
> --- a/drivers/net/wireless/ath/carl9170/phy.c
> +++ b/drivers/net/wireless/ath/carl9170/phy.c
> @@ -1139,7 +1139,6 @@ static int carl9170_set_freq_cal_data(struct ar9170 *ar,
>
> default:
> return -EINVAL;
> - break;
> }
>
> for (; i >= 0; i--) {
>

2014-07-21 08:20:26

by Fabian Frédérick

Subject: Re: [PATCH 14/30] ath6kl: remove unnecessary break after return

> On 21 July 2014 at 10:17 Kalle Valo <[email protected]> wrote:
>
>
> Fabian Frederick <[email protected]> writes:
>
> > Signed-off-by: Fabian Frederick <[email protected]>
>
> Acked-by: Kalle Valo <[email protected]>
>
> Who is taking this patch? Please let me know if I should apply it to my
> tree.

Thanks Kalle, David Miller already applied this patchset to net-next.

Regards,
Fabian
>
> --
> Kalle Valo

2014-07-20 14:26:45

by Fabian Frédérick

Subject: [PATCH 15/30] carl9170: remove unnecessary break after return

Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/net/wireless/ath/carl9170/phy.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/ath/carl9170/phy.c b/drivers/net/wireless/ath/carl9170/phy.c
index ab4ee7d..b80b213 100644
--- a/drivers/net/wireless/ath/carl9170/phy.c
+++ b/drivers/net/wireless/ath/carl9170/phy.c
@@ -1139,7 +1139,6 @@ static int carl9170_set_freq_cal_data(struct ar9170 *ar,

default:
return -EINVAL;
- break;
}

for (; i >= 0; i--) {
--
1.9.1

2014-07-20 14:26:40

by Fabian Frédérick

Subject: [PATCH 12/30] cw1200: remove unnecessary break after return

Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/net/wireless/cw1200/fwio.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/cw1200/fwio.c b/drivers/net/wireless/cw1200/fwio.c
index e23d67e..6f1b9aa 100644
--- a/drivers/net/wireless/cw1200/fwio.c
+++ b/drivers/net/wireless/cw1200/fwio.c
@@ -290,7 +290,6 @@ static int config_reg_write(struct cw1200_common *priv, u32 val)
case HIF_8601_SILICON:
default:
return cw1200_reg_write_32(priv, ST90TDS_CONFIG_REG_ID, val);
- break;
}
return 0;
}
--
1.9.1