To get rid of W=1 warning: variable ‘ies_len’ set but not used.
Variable ies_len is being assigned but never read.
Signed-off-by: Kenneth Lu <[email protected]>
---
drivers/net/wireless/ath/ath6kl/cfg80211.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
index b53eb2b..2ba8cf3 100644
--- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
+++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
@@ -2766,7 +2766,6 @@ static int ath6kl_start_ap(struct wiphy *wiphy, struct net_device *dev,
struct ieee80211_mgmt *mgmt;
bool hidden = false;
u8 *ies;
- int ies_len;
struct wmi_connect_cmd p;
int res;
int i, ret;
@@ -2804,7 +2803,6 @@ static int ath6kl_start_ap(struct wiphy *wiphy, struct net_device *dev,
ies = mgmt->u.beacon.variable;
if (ies > info->beacon.head + info->beacon.head_len)
return -EINVAL;
- ies_len = info->beacon.head + info->beacon.head_len - ies;
if (info->ssid == NULL)
return -EINVAL;
--
2.7.4
On Sat, Nov 25, 2017 at 9:38 PM, Kenneth Lu <[email protected]> wrote:
> To get rid of W=3D1 warning: variable =E2=80=98ies_len=E2=80=99 set but n=
ot used.
> Variable ies_len is being assigned but never read.
>
> Signed-off-by: Kenneth Lu <[email protected]>
> ---
> drivers/net/wireless/ath/ath6kl/cfg80211.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wir=
eless/ath/ath6kl/cfg80211.c
> index b53eb2b..2ba8cf3 100644
> --- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
> +++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
> @@ -2766,7 +2766,6 @@ static int ath6kl_start_ap(struct wiphy *wiphy, str=
uct net_device *dev,
> struct ieee80211_mgmt *mgmt;
> bool hidden =3D false;
> u8 *ies;
> - int ies_len;
> struct wmi_connect_cmd p;
> int res;
> int i, ret;
> @@ -2804,7 +2803,6 @@ static int ath6kl_start_ap(struct wiphy *wiphy, str=
uct net_device *dev,
> ies =3D mgmt->u.beacon.variable;
> if (ies > info->beacon.head + info->beacon.head_len)
> return -EINVAL;
> - ies_len =3D info->beacon.head + info->beacon.head_len - ies;
>
> if (info->ssid =3D=3D NULL)
> return -EINVAL;
Oddly, ies_len was never even used in the original patch that added
it. Probably used in some debugging code that was stripped before
submitting. Seems safe to kill it.
Reviewed-by: Steve deRosier <[email protected]>
- Steve
Kenneth Lu <[email protected]> wrote:
> To get rid of W=1 warning: variable ‘ies_len’ set but not used.
> Variable ies_len is being assigned but never read.
>
> Signed-off-by: Kenneth Lu <[email protected]>
> Reviewed-by: Steve deRosier <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
d786ebb2f59b ath6kl: remove redundant variable ies_len
--
https://patchwork.kernel.org/patch/10075235/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches