2009-05-29 08:40:12

by David Miller

Subject: [PATCH 4/10]: rtl8187: Remove pointless check in rtl8187_rx_cb().

First of all, it exposes the SKB list implementation.

Second of all it's not needed. If we get called here, we
successfully enqueued the URB with the linked SKB and
such a completion only gets called one time on such an
SKB.

Signed-off-by: David S. Miller <[email protected]>
---
drivers/net/wireless/rtl818x/rtl8187_dev.c | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/rtl818x/rtl8187_dev.c b/drivers/net/wireless/rtl818x/rtl8187_dev.c
index 6499ccc..3f22cc0 100644
--- a/drivers/net/wireless/rtl818x/rtl8187_dev.c
+++ b/drivers/net/wireless/rtl818x/rtl8187_dev.c
@@ -321,12 +321,7 @@ static void rtl8187_rx_cb(struct urb *urb)
unsigned long f;

spin_lock_irqsave(&priv->rx_queue.lock, f);
- if (skb->next)
- __skb_unlink(skb, &priv->rx_queue);
- else {
- spin_unlock_irqrestore(&priv->rx_queue.lock, f);
- return;
- }
+ __skb_unlink(skb, &priv->rx_queue);
spin_unlock_irqrestore(&priv->rx_queue.lock, f);
skb_put(skb, urb->actual_length);

--
1.6.3

2009-05-29 21:59:06

by David Miller

Subject: Re: [PATCH 4/10]: rtl8187: Remove pointless check in rtl8187_rx_cb().

From: Hin-Tak Leung <[email protected]>
Date: Fri, 29 May 2009 16:41:20 +0100

> I'll give this a try when I rebuild the rtl8187 module on my box.

Thank you.

2009-05-29 15:41:21

by Hin-Tak Leung

Subject: Re: [PATCH 4/10]: rtl8187: Remove pointless check in rtl8187_rx_cb().

On Fri, May 29, 2009 at 11:18 AM, John W. Linville
<[email protected]> wrote:
> On Fri, May 29, 2009 at 01:40:11AM -0700, David Miller wrote:
>>
>> First of all, it exposes the SKB list implementation.
>>
>> Second of all it's not needed. If we get called here, we
>> successfully enqueued the URB with the linked SKB and
>> such a completion only gets called one time on such an
>> SKB.
>>
>> Signed-off-by: David S. Miller <[email protected]>
>
> ACK

ACK.

I'll give this a try when I rebuild the rtl8187 module on my box.

Hin-Tak

2009-05-29 10:30:33

by John W. Linville

Subject: Re: [PATCH 4/10]: rtl8187: Remove pointless check in rtl8187_rx_cb().

On Fri, May 29, 2009 at 01:40:11AM -0700, David Miller wrote:
>
> First of all, it exposes the SKB list implementation.
>
> Second of all it's not needed. If we get called here, we
> successfully enqueued the URB with the linked SKB and
> such a completion only gets called one time on such an
> SKB.
>
> Signed-off-by: David S. Miller <[email protected]>

ACK

--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.