2009-06-16 02:44:14

by Hin-Tak Leung

[permalink] [raw]
Subject: vid/pid sorting patch? (Re: [PATCH] zd1211rw: adding 083a:e503 as a ZD1211B device)

Hiya,

The zd1211rw vid/pid list is getting a bit unruly - would it be
acceptable to submit a non-code-changing patch just to sort the ids?
It would just be tidier and make it easier to see what id is already
in and what is not, and also make it obvious where new changes should
be inserted. I know this affects git blame and other log searching
usage so may not be entirely desirable.

Hin-Tak


2009-06-16 16:28:07

by Hin-Tak Leung

[permalink] [raw]
Subject: Re: vid/pid sorting patch? (Re: [PATCH] zd1211rw: adding 083a:e503 as a ZD1211B device)

On Tue, Jun 16, 2009 at 5:33 AM, Luis R. Rodriguez<[email protected]> wrote:
> On Mon, Jun 15, 2009 at 7:36 PM, Hin-Tak Leung<[email protected]> wrote:
>> Hiya,
>>
>> The zd1211rw vid/pid list is getting a bit unruly - would it be
>> acceptable to submit a non-code-changing patch just to sort the ids?
>> It would just be tidier and make it easier to see what id is already
>> in and what is not, and also make it obvious where new changes should
>> be inserted. I know this affects git blame and other log searching
>> usage so may not be entirely desirable.
>
> Development on wireless-testing is always open, just send what you
> have and don't worry about where it can get applied.
>
> Luis

Okay - I'll submit a patch to sort the vid/pid's in zd1211rw in hex
order soon then.

Hin-Tak

2009-06-16 04:33:36

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: vid/pid sorting patch? (Re: [PATCH] zd1211rw: adding 083a:e503 as a ZD1211B device)

On Mon, Jun 15, 2009 at 7:36 PM, Hin-Tak Leung<[email protected]> wrote:
> Hiya,
>
> The zd1211rw vid/pid list is getting a bit unruly - would it be
> acceptable to submit a non-code-changing patch just to sort the ids?
> It would just be tidier and make it easier to see what id is already
> in and what is not, and also make it obvious where new changes should
> be inserted. I know this affects git blame and other log searching
> usage so may not be entirely desirable.

Development on wireless-testing is always open, just send what you
have and don't worry about where it can get applied.

Luis