2009-11-06 21:28:07

by Martín Ernesto Barreyro

[permalink] [raw]
Subject: Changing from Minstrel to PID

Hello, I have a rtl8187 wireless card and I've allways have problems
with the rate control using minstrel. So everytime my kernel updates
(recently it went from 2.30 to 2.31) i have to recompile mi kernel
setting pid as my default rate control algorithm.

Is there a way to change that without compiling the kernel?


--
Martín Ernesto Barreyro <[email protected]>
Analista Universitario en Redes de Datos.



2009-11-09 12:11:09

by Martín Ernesto Barreyro

[permalink] [raw]
Subject: Re: Changing from Minstrel to PID

2009/11/7 John W. Linville <[email protected]>:
> On Fri, Nov 06, 2009 at 08:01:33PM -0300, Mart?n Ernesto Barreyro wrote:
>> El vie, 06-11-2009 a las 16:48 -0500, John W. Linville escribi?:
>> > On Fri, Nov 06, 2009 at 06:29:16PM -0300, Mart?n Ernesto Barreyro wrote:
>> > > Hello, I have a rtl8187 wireless card and I've allways have problems
>> > > with the rate control using minstrel. So everytime my kernel updates
>> > > (recently it went from 2.30 to 2.31) i have to recompile mi kernel
>> > > setting pid as my default rate control algorithm.
>> > >
>> > > Is there a way to change that without compiling the kernel?
>> >
>> > No, but I wish there were...patches? ?Anyone?
>> >
>> > John
>>
>> I've been searching and it seems that it could be added something like
>> modprobe mac80211 rc='pid'
>>
>> Would it be a good idea?
>
> Well if you are happy with a module option, we already have
> ieee80211_default_rc_algo.
>
> John
> --
> John W. Linville ? ? ? ? ? ? ? ?Someday the world will need a hero, and you
> [email protected] ? ? ? ? ? ? ? ? ?might be all we have. ?Be ready.
>

Yes I'm happy, I'll try it.
Is there any other way that it can be approached?

2009-11-06 22:12:04

by Martín Ernesto Barreyro

[permalink] [raw]
Subject: Re: Changing from Minstrel to PID

El vie, 06-11-2009 a las 16:48 -0500, John W. Linville escribió:
> On Fri, Nov 06, 2009 at 06:29:16PM -0300, Martín Ernesto Barreyro wrote:
> > Hello, I have a rtl8187 wireless card and I've allways have problems
> > with the rate control using minstrel. So everytime my kernel updates
> > (recently it went from 2.30 to 2.31) i have to recompile mi kernel
> > setting pid as my default rate control algorithm.
> >
> > Is there a way to change that without compiling the kernel?
>
> No, but I wish there were...patches? Anyone?

Sorry for my ignorance, but how could I send a parameter to a module or
use a configuration file? could be with sysctl?


--
Martín Ernesto Barreyro <[email protected]>
Analista Universitario en Redes de Datos.


2009-11-09 15:57:27

by Hin-Tak Leung

[permalink] [raw]
Subject: Re: Changing from Minstrel to PID

On Mon, Nov 9, 2009 at 12:11 PM, Mart?n Ernesto Barreyro
<[email protected]> wrote:
> 2009/11/7 John W. Linville <[email protected]>:
>> On Fri, Nov 06, 2009 at 08:01:33PM -0300, Mart?n Ernesto Barreyro wrote:
>>> El vie, 06-11-2009 a las 16:48 -0500, John W. Linville escribi?:
>>> > On Fri, Nov 06, 2009 at 06:29:16PM -0300, Mart?n Ernesto Barreyro wrote:
>>> > > Hello, I have a rtl8187 wireless card and I've allways have problems
>>> > > with the rate control using minstrel. So everytime my kernel updates
>>> > > (recently it went from 2.30 to 2.31) i have to recompile mi kernel
>>> > > setting pid as my default rate control algorithm.
>>> > >
>>> > > Is there a way to change that without compiling the kernel?
>>> >
>>> > No, but I wish there were...patches? Anyone?
>>> >
>>> > John
>>>
>>> I've been searching and it seems that it could be added something like
>>> modprobe mac80211 rc='pid'
>>>
>>> Would it be a good idea?
>>
>> Well if you are happy with a module option, we already have
>> ieee80211_default_rc_algo.
>>
>> John
>> --
>> John W. Linville Someday the world will need a hero, and you
>> [email protected] might be all we have. Be ready.
>>
>
> Yes I'm happy, I'll try it.
> Is there any other way that it can be approached?
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

I suppose echo something into the /proc file system as john suggested
in an earlier post would be even better than a module option. That's a
bit more difficult to module option (module option is pretty much the
blunt hammer and you can replace any behavior with any other bahavor
with it, I think) as it makes the algorithm switch-able at run-time,
and that might be a little more tricky as one has to probably stop a
few things and restart a few things in the kernel... and I don't mean
debugfs, although since it is already in debugfs it might be easier
just to move that code out to general use.

2009-11-07 13:45:07

by John W. Linville

[permalink] [raw]
Subject: Re: Changing from Minstrel to PID

On Fri, Nov 06, 2009 at 05:24:47PM -0500, Bob Copeland wrote:
> On Fri, Nov 6, 2009 at 5:13 PM, Mart?n Ernesto Barreyro
> <[email protected]> wrote:
> >> No, but I wish there were...patches? ?Anyone?
> >
> > Sorry for my ignorance, but how could I send a parameter to a module or
> > use a configuration file? could be with sysctl?
>
> You do have to compile them both, but once you do, if you
> have debugfs mounted, you can do:
>
> echo 'pid' > /debug/ieee80211/phy0/rc/name
>
> to switch to pid.

Does that work? I thought that was only informational (and readonly)?

John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.

2009-11-06 22:24:43

by Bob Copeland

[permalink] [raw]
Subject: Re: Changing from Minstrel to PID

On Fri, Nov 6, 2009 at 5:13 PM, Mart?n Ernesto Barreyro
<[email protected]> wrote:
>> No, but I wish there were...patches? ?Anyone?
>
> Sorry for my ignorance, but how could I send a parameter to a module or
> use a configuration file? could be with sysctl?

You do have to compile them both, but once you do, if you
have debugfs mounted, you can do:

echo 'pid' > /debug/ieee80211/phy0/rc/name

to switch to pid.

--
Bob Copeland %% http://www.bobcopeland.com

2009-11-06 23:02:04

by Martín Ernesto Barreyro

[permalink] [raw]
Subject: Re: Changing from Minstrel to PID

El vie, 06-11-2009 a las 16:48 -0500, John W. Linville escribió:
> On Fri, Nov 06, 2009 at 06:29:16PM -0300, Martín Ernesto Barreyro wrote:
> > Hello, I have a rtl8187 wireless card and I've allways have problems
> > with the rate control using minstrel. So everytime my kernel updates
> > (recently it went from 2.30 to 2.31) i have to recompile mi kernel
> > setting pid as my default rate control algorithm.
> >
> > Is there a way to change that without compiling the kernel?
>
> No, but I wish there were...patches? Anyone?
>
> John

I've been searching and it seems that it could be added something like
modprobe mac80211 rc='pid'

Would it be a good idea?


--
Martín Ernesto Barreyro <[email protected]>
Analista Universitario en Redes de Datos.


2009-11-06 22:00:06

by John W. Linville

[permalink] [raw]
Subject: Re: Changing from Minstrel to PID

On Fri, Nov 06, 2009 at 06:29:16PM -0300, Mart?n Ernesto Barreyro wrote:
> Hello, I have a rtl8187 wireless card and I've allways have problems
> with the rate control using minstrel. So everytime my kernel updates
> (recently it went from 2.30 to 2.31) i have to recompile mi kernel
> setting pid as my default rate control algorithm.
>
> Is there a way to change that without compiling the kernel?

No, but I wish there were...patches? Anyone?

John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.

2009-11-07 12:23:53

by Hin-Tak Leung

[permalink] [raw]
Subject: Re: Changing from Minstrel to PID

On Fri, Nov 6, 2009 at 11:01 PM, Mart?n Ernesto Barreyro
<[email protected]> wrote:
> El vie, 06-11-2009 a las 16:48 -0500, John W. Linville escribi?:
>> On Fri, Nov 06, 2009 at 06:29:16PM -0300, Mart?n Ernesto Barreyro wrote:
>> > Hello, I have a rtl8187 wireless card and I've allways have problems
>> > with the rate control using minstrel. So everytime my kernel updates
>> > (recently it went from 2.30 to 2.31) i have to recompile mi kernel
>> > setting pid as my default rate control algorithm.
>> >
>> > Is there a way to change that without compiling the kernel?
>>
>> No, but I wish there were...patches? Anyone?
>>
>> John
>
> I've been searching and it seems that it could be added something like
> modprobe mac80211 rc='pid'
>
> Would it be a good idea?

That's a reasonable approach, and it isn't too difficult either -
somebody motivated enough could do a patch...

Hmm, I think I have a question and a suggestion here: what is it you
have problem with minstrel ? I don't care which one but both works
well enough here. Maybe you need that sorted instead.

The other thing is, you can probably patch compat-wireless to do
something similiar or at least experiment with it, as long as your
kernel is configured with most of them as modules. Switching
compat-wireless is quite easy, and particularly with the
'driver-select rtl818x' option you just rebuild about 6 kernel modules
instead of the usual 50+, which makes it quite quick and painless.

2009-11-07 17:26:43

by Bob Copeland

[permalink] [raw]
Subject: Re: Changing from Minstrel to PID

On Sat, Nov 07, 2009 at 08:43:30AM -0500, John W. Linville wrote:
> > echo 'pid' > /debug/ieee80211/phy0/rc/name
> >
> > to switch to pid.
>
> Does that work? I thought that was only informational (and readonly)?

Oh, yes, you are right. I was thinking of the ieee80211_default_rc_algo
modparam for mac80211.

--
Bob Copeland %% http://www.bobcopeland.com


2009-11-07 13:45:06

by John W. Linville

[permalink] [raw]
Subject: Re: Changing from Minstrel to PID

On Fri, Nov 06, 2009 at 08:01:33PM -0300, Mart?n Ernesto Barreyro wrote:
> El vie, 06-11-2009 a las 16:48 -0500, John W. Linville escribi?:
> > On Fri, Nov 06, 2009 at 06:29:16PM -0300, Mart?n Ernesto Barreyro wrote:
> > > Hello, I have a rtl8187 wireless card and I've allways have problems
> > > with the rate control using minstrel. So everytime my kernel updates
> > > (recently it went from 2.30 to 2.31) i have to recompile mi kernel
> > > setting pid as my default rate control algorithm.
> > >
> > > Is there a way to change that without compiling the kernel?
> >
> > No, but I wish there were...patches? Anyone?
> >
> > John
>
> I've been searching and it seems that it could be added something like
> modprobe mac80211 rc='pid'
>
> Would it be a good idea?

Well if you are happy with a module option, we already have
ieee80211_default_rc_algo.

John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.

2009-11-06 22:39:23

by Martín Ernesto Barreyro

[permalink] [raw]
Subject: Re: Changing from Minstrel to PID

El vie, 06-11-2009 a las 17:24 -0500, Bob Copeland escribió:
> On Fri, Nov 6, 2009 at 5:13 PM, Martín Ernesto Barreyro
> <[email protected]> wrote:
> >> No, but I wish there were...patches? Anyone?
> >
> > Sorry for my ignorance, but how could I send a parameter to a module or
> > use a configuration file? could be with sysctl?
>
> You do have to compile them both, but once you do, if you
> have debugfs mounted, you can do:
>
> echo 'pid' > /debug/ieee80211/phy0/rc/name
>
> to switch to pid.
>
Humm, if thats the only way, its better to recompile and forget about
it.

It would be nice if a could change some file in /etc and never care for
kernel upgrades.
I don't know much about kernel developing, i'm just wondering

Something better than adding echo 'pid' > /debug/ieee80211/phy0/rc/name
to rc.local

--
Martín Ernesto Barreyro <[email protected]>
Analista Universitario en Redes de Datos.