Hi Kalle Valo:
>-----?ʼ?ԭ??-----
>??????: Kalle Valo <[email protected]>
>????ʱ??: 2022??4??22?? 13:57
>?ռ???: Bernard Zhao <[email protected]>
>????: Jakub Kicinski <[email protected]>; David S. Miller <[email protected]>; Paolo Abeni <[email protected]>; Matthias Brugger <[email protected]>; [email protected]; [email protected]; >[email protected]; [email protected]; [email protected]; ?Ծ??? <[email protected]>
>????: Re: [PATCH] net/wireless: add debugfs exit function
>Bernard Zhao <[email protected]> writes:
>> This patch add exit debugfs function to mt7601u.
>> Debugfs need to be cleanup when module is unloaded or load fail.
>"load fail"? Please be more specific, are you saying that the second module load fails or what?
For this part, there are two cases:
First when mt7601u is loaded, in function mt7601u_probe, if function mt7601u_probe run into error lable err_hw, mt7601u_cleanup didn`t cleanup the debugfs node.
Second when the module disconnect, in function mt7601u_disconnect, mt7601u_cleanup didn`t cleanup the debugfs node.
I think these are the mt7601u unloaded or load fail cases, but both with no debugfs cleanup work.
>> drivers/net/wireless/mediatek/mt7601u/debugfs.c | 9 +++++++--
>> drivers/net/wireless/mediatek/mt7601u/init.c | 1 +
>> drivers/net/wireless/mediatek/mt7601u/mt7601u.h | 1 +
>The title should be:
>mt7601u: add debugfs exit function
Got it, thanks??
>> --- a/drivers/net/wireless/mediatek/mt7601u/debugfs.c
>> +++ b/drivers/net/wireless/mediatek/mt7601u/debugfs.c
>> @@ -9,6 +9,8 @@
>> #include "mt7601u.h"
>> #include "eeprom.h"
>>
>> +static struct dentry *dir;
>How will this work when there are multiple mt7601u devices? Because of that, avoid using non-const static variables.
Sorry for missing this part, I understand that the better way is to manage it in the struct of the matched device, I would fix this in the next patch.
Thank you very much!
BR//Bernard
>--
>https://patchwork.kernel.org/project/linux-wireless/list/
>https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches