2023-05-09 10:11:17

by Matthias Brugger

Subject: [PATCH] wifi: brcmfmac: wcc: Add debug messages

From: Matthias Brugger <[email protected]>

The message is attach and detach function are merly for debugging,
change them from pr_err to pr_debug.

Signed-off-by: Matthias Brugger <[email protected]>

---

drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c
index 02de99818efa..5573a47766ad 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c
@@ -12,13 +12,13 @@

static int brcmf_wcc_attach(struct brcmf_pub *drvr)
{
- pr_err("%s: executing\n", __func__);
+ pr_debug("%s: executing\n", __func__);
return 0;
}

static void brcmf_wcc_detach(struct brcmf_pub *drvr)
{
- pr_err("%s: executing\n", __func__);
+ pr_debug("%s: executing\n", __func__);
}

const struct brcmf_fwvid_ops brcmf_wcc_ops = {
--
2.40.1

2023-05-09 10:33:08

by Hans de Goede

Subject: Re: [PATCH] wifi: brcmfmac: wcc: Add debug messages

Hi,

On 5/9/23 12:04, [email protected] wrote:
> From: Matthias Brugger <[email protected]>
>
> The message is attach and detach function are merly for debugging,
> change them from pr_err to pr_debug.
>
> Signed-off-by: Matthias Brugger <[email protected]>

Thank you, I had writing this same patch on my own TODO list :)

Patch looks good to me:

Reviewed-by: Hans de Goede <[email protected]>

Regards,

Hans






> ---
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c
> index 02de99818efa..5573a47766ad 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c
> @@ -12,13 +12,13 @@
>
> static int brcmf_wcc_attach(struct brcmf_pub *drvr)
> {
> - pr_err("%s: executing\n", __func__);
> + pr_debug("%s: executing\n", __func__);
> return 0;
> }
>
> static void brcmf_wcc_detach(struct brcmf_pub *drvr)
> {
> - pr_err("%s: executing\n", __func__);
> + pr_debug("%s: executing\n", __func__);
> }
>
> const struct brcmf_fwvid_ops brcmf_wcc_ops = {

2023-05-15 18:32:41

by Kalle Valo

Subject: Re: wifi: brcmfmac: wcc: Add debug messages

[email protected] wrote:

> From: Matthias Brugger <[email protected]>
>
> The message is attach and detach function are merly for debugging,
> change them from pr_err to pr_debug.
>
> Signed-off-by: Matthias Brugger <[email protected]>
> Reviewed-by: Hans de Goede <[email protected]>

Patch applied to wireless-next.git, thanks.

87807f77a03d wifi: brcmfmac: wcc: Add debug messages

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches