2011-04-27 17:22:53

by Franky Lin

Subject: [PATCH] staging: brcm80211: Change print macro for debug only code

Change the debug macro from DHD_ERROR to DHD_INFO in
dhdsdio_sdiod_drive_strength_init to fix a compile error when
BCM_DEBUG is not turned on

Signed-off-by: Franky Lin <[email protected]>
---
drivers/staging/brcm80211/brcmfmac/dhd_sdio.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/brcm80211/brcmfmac/dhd_sdio.c b/drivers/staging/brcm80211/brcmfmac/dhd_sdio.c
index 6debc1e..299efa0 100644
--- a/drivers/staging/brcm80211/brcmfmac/dhd_sdio.c
+++ b/drivers/staging/brcm80211/brcmfmac/dhd_sdio.c
@@ -6363,7 +6363,7 @@ dhdsdio_sdiod_drive_strength_init(struct dhd_bus *bus, u32 drivestrength) {
str_shift = 11;
break;
default:
- DHD_ERROR(("No SDIO Drive strength init"
+ DHD_INFO(("No SDIO Drive strength init"
"done for chip %s rev %d pmurev %d\n",
bcm_chipname(bus->ci->chip, chn, 8),
bus->ci->chiprev, bus->ci->pmurev));
--
1.7.1

2011-04-27 17:38:51

by Franky Lin

Subject: RE: [PATCH] staging: brcm80211: Change print macro for debug only code

Hi Greg,

Please drop this patch. We will sync internally and send the patches out again. Sorry for the inconvenience.

Thanks
Franky

> -----Original Message-----
> From: [email protected] [mailto:linux-wireless-
> [email protected]] On Behalf Of Franky Lin
> Sent: Wednesday, April 27, 2011 10:23 AM
> To: [email protected]
> Cc: [email protected]; [email protected]; Brett
> Rudley; Henry Ptasinski; Howard Harte
> Subject: [PATCH] staging: brcm80211: Change print macro for debug only
> code
>
> Change the debug macro from DHD_ERROR to DHD_INFO in
> dhdsdio_sdiod_drive_strength_init to fix a compile error when
> BCM_DEBUG is not turned on
>
> Signed-off-by: Franky Lin <[email protected]>
> ---
> drivers/staging/brcm80211/brcmfmac/dhd_sdio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/brcm80211/brcmfmac/dhd_sdio.c
> b/drivers/staging/brcm80211/brcmfmac/dhd_sdio.c
> index 6debc1e..299efa0 100644
> --- a/drivers/staging/brcm80211/brcmfmac/dhd_sdio.c
> +++ b/drivers/staging/brcm80211/brcmfmac/dhd_sdio.c
> @@ -6363,7 +6363,7 @@ dhdsdio_sdiod_drive_strength_init(struct dhd_bus
> *bus, u32 drivestrength) {
> str_shift = 11;
> break;
> default:
> - DHD_ERROR(("No SDIO Drive strength init"
> + DHD_INFO(("No SDIO Drive strength init"
> "done for chip %s rev %d pmurev %d\n",
> bcm_chipname(bus->ci->chip, chn, 8),
> bus->ci->chiprev, bus->ci->pmurev));
> --
> 1.7.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-
> wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2011-04-27 22:14:49

by Greg KH

Subject: Re: [PATCH] staging: brcm80211: Change print macro for debug only code

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Wed, Apr 27, 2011 at 10:38:42AM -0700, Franky (Zhenhui) Lin wrote:
> Hi Greg,
>
> Please drop this patch. We will sync internally and send the patches
> out again. Sorry for the inconvenience.

dropped.