2008-07-20 03:52:05

by Nick Kossifidis

Subject: [PATCH 2/12] ath5k: Restore saved initval after POST

* Restore saved initial value after POST

Changes-licensed-under: ISC
Signed-off-by: Nick Kossifidis <[email protected]>

---
diff --git a/drivers/net/wireless/ath5k/hw.c b/drivers/net/wireless/ath5k/hw.c
index 2e60cf0..3e889f1 100644
--- a/drivers/net/wireless/ath5k/hw.c
+++ b/drivers/net/wireless/ath5k/hw.c
@@ -139,6 +139,8 @@ static int ath5k_hw_post(struct ath5k_hw *ah)
for (c = 0; c < 2; c++) {

cur_reg = regs[c];
+
+ /* Save previous value */
init_val = ath5k_hw_reg_read(ah, cur_reg);

for (i = 0; i < 256; i++) {
@@ -170,6 +172,10 @@ static int ath5k_hw_post(struct ath5k_hw *ah)
var_pattern = 0x003b080f;
ath5k_hw_reg_write(ah, var_pattern, cur_reg);
}
+
+ /* Restore previous value */
+ ath5k_hw_reg_write(ah, init_val, cur_reg);
+
}

return 0;

2008-07-24 21:40:07

by Pavel Roskin

Subject: Re: [PATCH 2/12] ath5k: Restore saved initval after POST

On Fri, 2008-07-25 at 00:36 +0300, Nick Kossifidis wrote:
> 2008/7/25 Pavel Roskin <[email protected]>:
> > On Sun, 2008-07-20 at 06:32 +0300, Nick Kossifidis wrote:
> >> * Restore saved initial value after POST
> > ...
> >> @@ -170,6 +172,10 @@ static int ath5k_hw_post(struct ath5k_hw *ah)
> >> var_pattern = 0x003b080f;
> >> ath5k_hw_reg_write(ah, var_pattern, cur_reg);
> >> }
> >> +
> >> + /* Restore previous value */
> >> + ath5k_hw_reg_write(ah, init_val, cur_reg);
> >> +
> >> }
> >
> > Perhaps "at the end of POST"? Anyway, the code looks good to me.
> >
>
> We are not restoring at the end of POST but after we end with each of
> the two registers, so i guess it's ok this way

OK, fine with me.

--
Regards,
Pavel Roskin

2008-07-24 21:26:30

by Pavel Roskin

Subject: Re: [PATCH 2/12] ath5k: Restore saved initval after POST

On Sun, 2008-07-20 at 06:32 +0300, Nick Kossifidis wrote:
> * Restore saved initial value after POST
...
> @@ -170,6 +172,10 @@ static int ath5k_hw_post(struct ath5k_hw *ah)
> var_pattern = 0x003b080f;
> ath5k_hw_reg_write(ah, var_pattern, cur_reg);
> }
> +
> + /* Restore previous value */
> + ath5k_hw_reg_write(ah, init_val, cur_reg);
> +
> }

Perhaps "at the end of POST"? Anyway, the code looks good to me.

--
Regards,
Pavel Roskin

2008-07-24 21:36:26

by Nick Kossifidis

Subject: Re: [PATCH 2/12] ath5k: Restore saved initval after POST

2008/7/25 Pavel Roskin <[email protected]>:
> On Sun, 2008-07-20 at 06:32 +0300, Nick Kossifidis wrote:
>> * Restore saved initial value after POST
> ...
>> @@ -170,6 +172,10 @@ static int ath5k_hw_post(struct ath5k_hw *ah)
>> var_pattern = 0x003b080f;
>> ath5k_hw_reg_write(ah, var_pattern, cur_reg);
>> }
>> +
>> + /* Restore previous value */
>> + ath5k_hw_reg_write(ah, init_val, cur_reg);
>> +
>> }
>
> Perhaps "at the end of POST"? Anyway, the code looks good to me.
>

We are not restoring at the end of POST but after we end with each of
the two registers, so i guess it's ok this way



--
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick