Hi,
this is the next RFC round...
1) rename all prism54* to p54* (to match the filenames)
2) rx_tasklet for p54pci
3) link statistics
4) AP-Patch
Signed-off-by: Christian Lamparter <[email protected]>
---
diffstat:
p54.h | 40 ++++
p54common.c | 487
++++++++++++++++++++++++++++++++++++++++++++++++------------
p54common.h | 111 ++++++++++---
p54pci.c | 283 ++++++++++++++++++++++------------
p54pci.h | 20 +-
p54usb.c | 34 ++--
p54usb.h | 6
7 files changed, 726 insertions(+), 255 deletions(-)
Give it a good testing!
Notes:
- IBSS mode is maybe a buggy, but it'll take another semester break to figure
out whats wrong with the TSF timer.
- Powersaving package queueing is disabled in AP-Mode. As my Intel 4965N
won't reconnect with it. (but the atheros card does?!)
BTW:
since no one has the codebase to p54/, or made any other changes I made the
(all-in-on) diff against the (old) kernel-code... but with the _new_ path!
if you want to test it, don't forget the mac80211 patch!
http://article.gmane.org/gmane.linux.kernel.wireless.general/13115
Regards,
Chr.
On Tue, Apr 1, 2008 at 5:39 PM, Chr <[email protected]> wrote:
> Hi,
>
> this is the next RFC round...
>
> 1) rename all prism54* to p54* (to match the filenames)
> 2) rx_tasklet for p54pci
> 3) link statistics
> 4) AP-Patch
>
> Signed-off-by: Christian Lamparter <[email protected]>
Thanks, can you resend as inline patches so it can help get better
review. Also while you're at it can you stuff all p54 files into its
own folder?
Luis
On Friday 04 April 2008 00:34:35 Luis R. Rodriguez wrote:
> On Thu, Apr 3, 2008 at 11:40 AM, Chr <[email protected]> wrote:
> > On Thursday 03 April 2008 01:42:59 Luis R. Rodriguez wrote:
> > > Thanks, can you resend as inline patches so it can help get better
> > > review. Also while you're at it can you stuff all p54 files into its
> > > own folder?
> >
> > hmm, I can.... but:
> > - in which folder? for now.. I put everything into a new one folder
> > named p54, but as you know the fullmac driver has already the prism54
> > subdirectory... should I put it there? or is this confusing?
>
> p54 directory works nice. Now that you are introducing master mode the
> only thing left I think is IBSS compared to prism54, and if that is
> done I think we should *consider* removing prism54 driver after one
> release cycle of the kernel. I once was told that for some cards the
> softmac driver wouldn't work on some fullmac chipsets. I have yet to
> hear of someone who found these type of cards though. I know we also
> had some WDS code for prism54 lying around, it just never got merged
> in because Jeff didn't find it widely used and IIRC it needed a little
> more cleanup.
>
> Think you can get IBSS and maybe WDS to work too?
>
Hmm, AFAIK they were thinking of the 3877 (802.11a only)... I guess this one
won't work with p54. But have you ever see anyone (except the
Intersil/Conexant people) with a 5Ghz prism card at all? It'll be interesting
to get a eeprom dump from them...
About WDS: is there anything special about WDS, that I should know?
Since, I thought it's entirely done by mac80211 by now?
About IBSS: yes, it is kind of working... I'll put some code for this in the
next round.
> > - the resulting patch is too big to post it here, ~ 271kb as
> > plaintext... is a bz2 (32kb) attachment ok too?
>
> Oh OK, I see. Can you perhaps split the big patch up into a few series?
that'll be about 3 or 4 parts... tomorrow! I have to figure out how
I can split up the _big_ one.
Regards,
Chr
On Thursday 03 April 2008 01:42:59 Luis R. Rodriguez wrote:
>
> Thanks, can you resend as inline patches so it can help get better
> review. Also while you're at it can you stuff all p54 files into its
> own folder?
hmm, I can.... but:
- in which folder? for now.. I put everything into a new one folder named p54,
but as you know the fullmac driver has already the prism54 subdirectory...
should I put it there? or is this confusing?
- the resulting patch is too big to post it here, ~ 271kb as plaintext...
is a bz2 (32kb) attachment ok too?
diffstat:
b/drivers/net/wireless/Kconfig | 65 --
b/drivers/net/wireless/Makefile | 4
b/drivers/net/wireless/p54/Kconfig | 63 +
b/drivers/net/wireless/p54/Makefile | 3
b/drivers/net/wireless/p54/net2280.h | 452 ++++++++++++++
b/drivers/net/wireless/p54/p54.h | 77 ++
b/drivers/net/wireless/p54/p54common.c | 1051
+++++++++++++++++++++++++++++++++
b/drivers/net/wireless/p54/p54common.h | 254 +++++++
b/drivers/net/wireless/p54/p54pci.c | 697 +++++++++++++++++++++
b/drivers/net/wireless/p54/p54pci.h | 106 +++
b/drivers/net/wireless/p54/p54usb.c | 910 ++++++++++++++++++++++++++++
b/drivers/net/wireless/p54/p54usb.h | 133 ++++
drivers/net/wireless/net2280.h | 452 --------------
drivers/net/wireless/p54.h | 77 --
drivers/net/wireless/p54common.c |
1051 ---------------------------------
drivers/net/wireless/p54common.h | 254 -------
drivers/net/wireless/p54pci.c | 697 ---------------------
drivers/net/wireless/p54pci.h | 106 ---
drivers/net/wireless/p54usb.c | 910 ----------------------------
drivers/net/wireless/p54usb.h | 133 ----
20 files changed, 3748 insertions(+), 3747 deletions(-)
Regards,
Chr
On Thu, Apr 3, 2008 at 11:40 AM, Chr <[email protected]> wrote:
> On Thursday 03 April 2008 01:42:59 Luis R. Rodriguez wrote:
> >
> > Thanks, can you resend as inline patches so it can help get better
> > review. Also while you're at it can you stuff all p54 files into its
> > own folder?
> hmm, I can.... but:
> - in which folder? for now.. I put everything into a new one folder named p54,
> but as you know the fullmac driver has already the prism54 subdirectory...
> should I put it there? or is this confusing?
p54 directory works nice. Now that you are introducing master mode the
only thing left I think is IBSS compared to prism54, and if that is
done I think we should *consider* removing prism54 driver after one
release cycle of the kernel. I once was told that for some cards the
softmac driver wouldn't work on some fullmac chipsets. I have yet to
hear of someone who found these type of cards though. I know we also
had some WDS code for prism54 lying around, it just never got merged
in because Jeff didn't find it widely used and IIRC it needed a little
more cleanup.
Think you can get IBSS and maybe WDS to work too?
> - the resulting patch is too big to post it here, ~ 271kb as plaintext...
> is a bz2 (32kb) attachment ok too?
Oh OK, I see. Can you perhaps split the big patch up into a few series?
Luis